From: Junio C Hamano <gitster@pobox.com>
To: "Randall S. Becker" <rsbecker@nexbridge.com>
Cc: <git@vger.kernel.org>, "'Tanay Abhra'" <tanayabh@gmail.com>,
"'Matthieu Moy'" <git@matthieu-moy.fr>
Subject: Re: [ANNOUNCE] Git v2.16.0-rc2 - breakages in t1308 and 1404
Date: Fri, 12 Jan 2018 15:27:41 -0800 [thread overview]
Message-ID: <xmqqy3l2ves2.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <008f01d38bfa$7eba9bc0$7c2fd340$@nexbridge.com> (Randall S. Becker's message of "Fri, 12 Jan 2018 18:10:05 -0500")
"Randall S. Becker" <rsbecker@nexbridge.com> writes:
> Sadly, fixing the "except" thing causes the test to break now.
That is exactly what I wanted to say. If you want to "fix" it,
you'd need to figure out what the author of the "except" thing
wanted to test, adjust the args given to test-config (it cannot be
the same as the test-config invocation of the previous test), and
then fix the typo s/except/expect/. Changing the typo alone *will*
of course make the test fail, because then the file with the
corrected name, i.e. "expect", has bogus lines that does not match
how the current invocation of "test-config" command is expected to
output.
> sense of the intent of this, unless the test is to find unmatching keys and
> it really does mean "except"
> --- expect 2018-01-12 23:03:41 +0000
> +++ actual 2018-01-12 23:03:41 +0000
> @@ -1,5 +1 @@
> -sam
> -bat
> hask
> -lama
> -ball
>
> [case]
> baz = lama
> [my]
> new = silk
> [case]
> baz = ball
next prev parent reply other threads:[~2018-01-12 23:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 19:42 [ANNOUNCE] Git v2.16.0-rc2 - breakages in t1308 and 1404 Randall S. Becker
2018-01-12 22:07 ` Junio C Hamano
2018-01-12 23:10 ` Randall S. Becker
2018-01-12 23:27 ` Junio C Hamano [this message]
2018-01-13 2:51 ` Tanay Abhra
2018-01-16 18:19 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy3l2ves2.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@matthieu-moy.fr \
--cc=git@vger.kernel.org \
--cc=rsbecker@nexbridge.com \
--cc=tanayabh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.