From: Junio C Hamano <gitster@pobox.com>
To: Johannes Sixt <j6t@kdbg.org>
Cc: Stefan Beller <sbeller@google.com>,
git@vger.kernel.org, peff@peff.net, jens.lehmann@web.de
Subject: Re: [PATCHv3] submodule: Port resolve_relative_url from shell to C
Date: Wed, 13 Jan 2016 08:58:13 -0800 [thread overview]
Message-ID: <xmqqy4btpgbe.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <5695FFDA.9050409@kdbg.org> (Johannes Sixt's message of "Wed, 13 Jan 2016 08:42:18 +0100")
Johannes Sixt <j6t@kdbg.org> writes:
> Am 13.01.2016 um 01:10 schrieb Stefan Beller:
>> Later on we want to deprecate the `git submodule init` command and make
>> it implicit in other submodule commands. As these other commands are
>> written in C already, we'd need the init functionality in C, too.
>> The `resolve_relative_url` function is a major part of that init
>> functionality, so start by porting this function to C.
>
> Maybe tone down the word "major" to "a large and non-trivial function"?
> Otherwise, the lack of proof for the claim is irritating. (As we saw,
> the savings with the port to C are not breath-taking. But we have to
> start somewhere.)
> ...
All good suggestions. Thanks for a low latency review. Very much
appreciated.
prev parent reply other threads:[~2016-01-13 16:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-12 23:35 [PATCHv2] submodule: Port resolve_relative_url from shell to C Stefan Beller
2016-01-13 0:10 ` [PATCHv3] " Stefan Beller
2016-01-13 7:42 ` Johannes Sixt
2016-01-13 16:58 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy4btpgbe.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=jens.lehmann@web.de \
--cc=peff@peff.net \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.