All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Torsten Bögershausen" <tboegi@web.de>
Cc: Jeff King <peff@peff.net>,
	"Reid Woodbury Jr." <reidw@rawsound.com>,
	git@vger.kernel.org
Subject: Re: git 2.3.4, ssh: Could not resolve hostname
Date: Fri, 03 Apr 2015 14:01:55 -0700	[thread overview]
Message-ID: <xmqqy4m9exj0.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <551DD887.2010403@web.de> ("Torsten Bögershausen"'s message of "Fri, 03 Apr 2015 02:02:15 +0200")

Torsten Bögershausen <tboegi@web.de> writes:

> This makes my think that it is
> a) non-standard to have the extra colon
> b) The error message could be better

For that, perhaps

-ssh: Could not resolve hostname xxxx:: nodename nor servname provided, or not known
+ssh: Could not resolve hostname "xxxx:": nodename nor servname provided, or not known

would be something we would want to do, no matter what other fixes
we would apply.

> Spontaneously I would say that a trailing ':' at the end of a
> hostname in the ssh:// scheme can be safely ignored, what do you
> think?

If it is not too much hassle to make the current code do so, I'd say
that is a good way forward.  Giving a warning that lets the user
know that the input has an extra and unwanted colon in it may be a
plus, too.

Thanks.

  parent reply	other threads:[~2015-04-03 21:02 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-02 17:18 git 2.3.4, ssh: Could not resolve hostname Reid Woodbury Jr.
2015-04-02 18:09 ` Jeff King
2015-04-02 18:58   ` Reid Woodbury Jr.
2015-04-02 19:14     ` Jeff King
2015-04-02 19:24       ` Junio C Hamano
2015-04-02 19:31         ` Reid Woodbury Jr.
2015-04-02 19:35           ` Jeff King
2015-04-02 20:06             ` Reid Woodbury Jr.
2015-04-02 20:15               ` Thomas Schneider
2015-04-03  0:02             ` Torsten Bögershausen
2015-04-03  1:30               ` brian m. carlson
2015-04-03 21:01               ` Junio C Hamano [this message]
2015-04-03 21:05                 ` Jeff King
2015-04-03 21:32               ` Kyle J. McKay
2015-04-04  0:19                 ` Reid Woodbury Jr.
2015-04-04  7:21                   ` Torsten Bögershausen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqy4m9exj0.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=reidw@rawsound.com \
    --cc=tboegi@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.