From: Junio C Hamano <gitster@pobox.com>
To: Koosha Khajehmoogahi <koosha@posteo.de>
Cc: git <git@vger.kernel.org>
Subject: Re: [PATCH] [RFC] Add a new config. option for skipping merges in git-log
Date: Mon, 16 Mar 2015 13:50:40 -0700 [thread overview]
Message-ID: <xmqqy4mwpsyn.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <5507301B.2060401@posteo.de> (Koosha Khajehmoogahi's message of "Mon, 16 Mar 2015 20:33:47 +0100")
Koosha Khajehmoogahi <koosha@posteo.de> writes:
> Thanks for your suggestions. The "extra bit" in rev_info is used when
> we need to compare user's command-line input to his configuration. Since
> command-line input is processed in revision.c but config. options are read
> in builtin/log.c, we need a way to pass the value to builtin/log.c. How
> would you do that without this extra bit?
The command line overrides the config, no? If you set up what the
command line defaults to from the config, let the command line
parser do whatever it wants to do, and do nothing else after the
command line parser returns, wouldn't that be sufficient?
Puzzled...
next prev parent reply other threads:[~2015-03-16 20:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 14:23 [PATCH] [RFC] Add a new config. option for skipping merges in git-log Koosha Khajehmoogahi
2015-03-16 15:27 ` Koosha Khajehmoogahi
2015-03-16 16:04 ` Koosha Khajehmoogahi
2015-03-16 17:53 ` Junio C Hamano
2015-03-16 19:33 ` Koosha Khajehmoogahi
2015-03-16 20:50 ` Junio C Hamano [this message]
2015-03-16 20:59 ` Koosha Khajehmoogahi
2015-03-16 21:58 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy4mwpsyn.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=koosha@posteo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.