From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: Christian Couder <chriscool@tuxfamily.org>, git <git@vger.kernel.org>
Subject: Re: [PATCH 1/3] trailer: add a trailer.trimEmpty config option
Date: Mon, 09 Feb 2015 10:23:33 -0800 [thread overview]
Message-ID: <xmqqy4o7aqqi.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAP8UFD1pWH5yaJaJ_gV1t5q5qfgs58AtcSr+ZqDTnWzfHK1uBw@mail.gmail.com> (Christian Couder's message of "Sat, 7 Feb 2015 23:19:31 +0100")
Christian Couder <christian.couder@gmail.com> writes:
> It is not designed like this because you only asked me to design it
> like this after the facts, when there was another email thread about
> conflicts blocks and one function you created could be used by the
> trailer code too.
>
> If you had asked this from the beginning I would certainly have done...
Because the process here is not somebody outlines the design and
gives it to laborer to implement, "after the fact" and "from the
beginning" are complaining to and asking for impossible. You design
and implement and then it gets reviewed, not the other way around.
next prev parent reply other threads:[~2015-02-09 18:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-07 13:11 [PATCH 1/3] trailer: add a trailer.trimEmpty config option Christian Couder
2015-02-07 20:20 ` Junio C Hamano
2015-02-07 22:19 ` Christian Couder
2015-02-09 18:23 ` Junio C Hamano [this message]
2015-02-10 21:58 ` Junio C Hamano
2015-02-10 22:06 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy4o7aqqi.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.