From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Manzur Mukhitdinov <manzurmm@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] replace: fix replacing object with itself
Date: Sun, 09 Nov 2014 09:35:52 -0800 [thread overview]
Message-ID: <xmqqy4rkcm4n.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20141109055842.GB13445@peff.net> (Jeff King's message of "Sun, 9 Nov 2014 00:58:43 -0500")
Jeff King <peff@peff.net> writes:
> I think all of the callers of replace_object_sha1 do this same check
> now. Can we just move the check into that function instead of adding
> another instance of it?
Good thinking. Thanks.
next prev parent reply other threads:[~2014-11-09 17:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-09 0:05 [PATCH] replace: fix replacing object with itself Manzur Mukhitdinov
2014-11-09 5:58 ` Jeff King
2014-11-09 17:35 ` Junio C Hamano [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-11-10 23:20 Manzur Mukhitdinov
2014-11-11 3:03 ` Jeff King
2014-11-13 14:05 Manzur Mukhitdinov
2014-11-14 22:45 ` Junio C Hamano
2014-11-15 11:55 ` Christian Couder
2014-11-16 18:59 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy4rkcm4n.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=manzurmm@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.