From: Junio C Hamano <gitster@pobox.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] remote-helpers: move tests out of contrib
Date: Mon, 21 Apr 2014 12:24:10 -0700 [thread overview]
Message-ID: <xmqqy4yy8p0l.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <5355690fbe8ad_32c4849310d1@nysa.notmuch> (Felipe Contreras's message of "Mon, 21 Apr 2014 13:53:03 -0500")
Felipe Contreras <felipe.contreras@gmail.com> writes:
>> This step needs a bit more work, I am afraid, to at least have these
>> three test scripts follow the same numbering scheme. Especially given
>> that there were recent discussions on allowing a range of tests to
>> be run (or omitted) via notations like "5000,5020,9800-9812", not
>> doing so now will make it harder to implement such an enhancement.
>
> I don't see how such an enhancement would be beneficial to these remote
> helpers.
Why are remote helpers more special than other parts of the system?
Do they _have to_ be different and special?
> For starters there aren't any number rages left for them,...
Wouldn't "5 - the pull and exporting" be an obvious space for them,
especiall somewhere after 5800?
> There might be other practical reasons to use this numbering scheme (although
> I'm sure the scripts could be fixed to not assume those),...
;-) Yes, as long as you can program it, anything is possible.
>> Can we squelch these expected import error messages?
>
> Sure:
Then I'd expect a reroll, at least to 2/2 (I do not think I saw
anything iffy in 1/2).
Thanks.
next prev parent reply other threads:[~2014-04-21 19:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-20 21:39 [PATCH 0/2] remote-helpers: graduate Felipe Contreras
2014-04-20 21:39 ` [PATCH 1/2] remote-helpers: move out of contrib Felipe Contreras
2014-04-20 21:39 ` [PATCH 2/2] remote-helpers: move tests " Felipe Contreras
2014-04-21 18:36 ` Junio C Hamano
2014-04-21 18:53 ` Felipe Contreras
2014-04-21 19:24 ` Junio C Hamano [this message]
2014-04-21 19:23 ` Felipe Contreras
2014-04-21 18:06 ` [PATCH 0/2] remote-helpers: graduate Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy4yy8p0l.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.