From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: [PATCH] GIT-VERSION-GEN: Do not require tags to be annotated Date: Tue, 10 Sep 2013 08:59:34 -0700 Message-ID: References: <522A36AA.3050701@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Git Mailing List To: Sebastian Schuberth X-From: git-owner@vger.kernel.org Tue Sep 10 17:59:43 2013 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VJQLv-0004Re-8H for gcvg-git-2@plane.gmane.org; Tue, 10 Sep 2013 17:59:43 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752027Ab3IJP7j (ORCPT ); Tue, 10 Sep 2013 11:59:39 -0400 Received: from b-pb-sasl-quonix.pobox.com ([208.72.237.35]:57315 "EHLO smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751719Ab3IJP7i (ORCPT ); Tue, 10 Sep 2013 11:59:38 -0400 Received: from smtp.pobox.com (unknown [127.0.0.1]) by b-sasl-quonix.pobox.com (Postfix) with ESMTP id 0248840165; Tue, 10 Sep 2013 15:59:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=2uxU2LPwgt9c24a/5l1zeQDphQs=; b=NwVkv+ eJ5w/ihS+0nBTnpveEH1Mk9pVn37qq14KdOGWwmp/hJptBy/ovCQpn1zpqNqlENs k1XWSbD1sOHYpLQSwvo4LdMzCCAJmMwtzrpYZm1wtgldTmykdo1w9AfZBQQvq7wh IwR6fdHkP97+nJj9c5UmZHwIgs7qQty9C+6k8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=n4/xWVf/V6H4kOrzvRANZu0JXlajRIAS GCpQPtJvOMC9Eo2ADNRP9FOzU7EBPK8Ud9Fxu/m16rq2S3yYPvMj+FzdX9lPvZE9 s1b9VnIZff5dP88AOyJohyzFV5JSohX3dAJ2PJ/EL4/08Y+hsWpCJcMGkvhjkwKs IjIFgSQuDrU= Received: from b-pb-sasl-quonix.pobox.com (unknown [127.0.0.1]) by b-sasl-quonix.pobox.com (Postfix) with ESMTP id E1F5840162; Tue, 10 Sep 2013 15:59:37 +0000 (UTC) Received: from pobox.com (unknown [72.14.226.9]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by b-sasl-quonix.pobox.com (Postfix) with ESMTPSA id CF53F4015B; Tue, 10 Sep 2013 15:59:36 +0000 (UTC) In-Reply-To: (Sebastian Schuberth's message of "Tue, 10 Sep 2013 10:06:37 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) X-Pobox-Relay-ID: FE18B0B2-1A31-11E3-A527-CA9B8506CD1E-77302942!b-pb-sasl-quonix.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Sebastian Schuberth writes: > Right, but do we really need DEF_VER *and* version? Couldn't we just > package official source tarballs in a way that they already contain an > auto-generated version file? If you read our Makefile, you will see that we do include the version file in our official tarball with "make dist". That however does not help those who use a tarball obtained from git-archive, perhaps via gitweb running at the distribution site. Theoretically speaking, you can rip out everything but "version" and tell those who have been relying on the way other parts of G-V-G worked to change their workflow to stuff their favorite version string to that file before building, so in that sense, we do not *need* DEF_VER and version. But they have been there for a long time, and I do not think it gives us a good trade-off between risking regression and reducing the linecount to change it to remove one.