From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Nov 2026, #01)
Date: Wed, 04 Nov 2026 10:09:20 -0800 [thread overview]
Message-ID: <xmqqzevo1nan.fsf@gitster.g> (raw)
In-Reply-To: <20261104064115.GD1543013@coredump.intra.peff.net> (Jeff King's message of "Wed, 4 Nov 2026 01:41:15 -0500")
Jeff King <peff@peff.net> writes:
> On Mon, Nov 02, 2026 at 06:31:14PM -0800, Junio C Hamano wrote:
>
>> * jk/test-env-quoting-fix (2026-10-30) 1 commit
>> - t5702: be more resilient to env quoting
>>
>> Tests in 't5702' that grep the output of 'env' to check for the
>> 'GIT_PROTOCOL' environment variable have been updated to explicitly
>> echo the variable instead, making them resilient to quoting changes
>> introduced in newer GNU coreutils.
>>
>> Will merge to 'next'?
>> cf. <xmqqwlqytvg9.fsf@gitster.g>
>> source: <20261031002550.GA626623@coredump.intra.peff.net>
>
> It sounds from the discussion in the thread that the coreutils behavior
> has changed so that this becomes a non-issue. And I just double-checked
> that the version in debian unstable now works without the patch. That
> said, I think the code after the patch is more robust in general. IMHO
> it's still worth doing.
Yes, I agree that your change to make the test immune to the way how
variables and their values are quoted by "env" is a good thing.
prev parent reply other threads:[~2026-11-04 18:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 2:31 What's cooking in git.git (Nov 2026, #01) Junio C Hamano
2026-11-04 6:41 ` Jeff King
2026-11-04 18:09 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzevo1nan.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.