From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Muhammed Dilshad A <dilsheddilu123@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] test-mergesort: plug memory leaks in sort_stdin()
Date: Wed, 07 Oct 2026 10:27:03 -0700 [thread overview]
Message-ID: <xmqqzewp8lqw.fsf@gitster.g> (raw)
In-Reply-To: <asXi-1RlWhqPMWjL@pks.im> (Patrick Steinhardt's message of "Wed, 7 Oct 2026 08:13:15 +0200")
Patrick Steinhardt <ps@pks.im> writes:
> I was briefly wondering whether we could get rid of t0071 altogether in
> favor of converting the tests into a unit test, and then drop the test
> helper. And that's certainly doable, and I'd argue it would also be the
> right thing to do.
Yup, unlike any "test-tool" feature that is specific to some Git
operation, things like mergesort does not need to be part of
end-to-end t[0-9]{4}-*.sh test suite.
> But anyway, that's of course a much bigger scope, and I'm fine to just
> fix the bugs for now.
;-).
> I noticed that there's another "generate" subcommand here that is
> entirely unused. Do we maybe want to also remove it while at it? The
> test suite passes with the below diff.
Great.
Thanks.
next prev parent reply other threads:[~2026-10-07 17:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-07 3:42 [PATCH] test-mergesort: plug memory leaks in sort_stdin() Muhammed Dilshad A
2026-10-07 6:13 ` Patrick Steinhardt
2026-10-07 17:27 ` Junio C Hamano [this message]
2026-10-07 13:50 ` [PATCH v2 0/3] mergesort: move tests to Clar and retire the helper Muhammed Dilshad A
2026-10-07 13:50 ` [PATCH v2 1/3] test-mergesort: plug memory leaks in sort_stdin() Muhammed Dilshad A
2026-10-07 13:50 ` [PATCH v2 2/3] mergesort: move sorting tests to the unit-test framework Muhammed Dilshad A
2026-10-09 11:52 ` Patrick Steinhardt
2026-10-09 13:55 ` Muhammed Dilshad A
2026-10-07 13:50 ` [PATCH v2 3/3] t: retire the sorting benchmark and mergesort helper Muhammed Dilshad A
2026-10-09 11:52 ` [PATCH v2 0/3] mergesort: move tests to Clar and retire the helper Patrick Steinhardt
2026-10-09 13:56 ` Muhammed Dilshad A
2026-10-09 15:08 ` [PATCH v3 0/4] mergesort: move tests to Clar and remove " Muhammed Dilshad A
2026-10-09 15:08 ` [PATCH v3 1/4] mergesort: move sorting tests to Clar Muhammed Dilshad A
2026-10-11 7:07 ` Junio C Hamano
2026-10-12 4:11 ` Muhammed Dilshad A
2026-10-09 15:08 ` [PATCH v3 2/4] mergesort: simplify the unit tests Muhammed Dilshad A
2026-10-09 15:08 ` [PATCH v3 3/4] mergesort: cover empty and small lists Muhammed Dilshad A
2026-10-09 15:08 ` [PATCH v3 4/4] t: retire the sorting benchmark and mergesort helper Muhammed Dilshad A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzewp8lqw.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=dilsheddilu123@gmail.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.