All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Phillip Wood <phillip.wood123@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] stash: use named constant when parsing "--all"
Date: Sun, 04 Oct 2026 22:27:27 -0700	[thread overview]
Message-ID: <xmqqzewsogxs.fsf@gitster.g> (raw)
In-Reply-To: <06b58ae0a1d81f4d1518eadecc3385072a72155a.1791108351.git.phillip.wood@dunelm.org.uk> (Phillip Wood's message of "Sun, 4 Oct 2026 11:05:52 +0100")

Phillip Wood <phillip.wood123@gmail.com> writes:

> From: Phillip Wood <phillip.wood@dunelm.org.uk>
>
> The code that stashes all untracked files compares the value of the
> "include_untracked" variable to the constant "INCLUDE_ALL_FILES",
> however the option parsing code for "--all" uses a hard coded integer
> instead. Replace the integer with the named constant.
>
> Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk>
> ---
> -			    N_("include ignore files"), 2),
> +			    N_("include ignore files"), INCLUDE_ALL_FILES),
> -			    N_("include ignore files"), 2),
> +			    N_("include ignore files"), INCLUDE_ALL_FILES),

So obviously right.  I wish all patches were like this ;-).

      reply	other threads:[~2026-10-05  5:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-04 10:05 [PATCH] stash: use named constant when parsing "--all" Phillip Wood
2026-10-05  5:27 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqzewsogxs.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=phillip.wood123@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.