All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Chen Linxuan via B4 Relay <devnull+me.black-desk.cn@kernel.org>
Cc: git@vger.kernel.org,
	 Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>,
	 Patrick Steinhardt <ps@pks.im>,  Chen Linxuan <me@black-desk.cn>,
	 Phillip Wood <phillip.wood@dunelm.org.uk>
Subject: Re: [PATCH v7 0/3] includeIf: add "worktree" condition for matching working tree path
Date: Thu, 09 Jul 2026 13:40:21 -0700	[thread overview]
Message-ID: <xmqqzezzkibu.fsf@gitster.g> (raw)
In-Reply-To: <20260709-includeif-worktree-v7-0-e87e705e8df6@black-desk.cn> (Chen Linxuan via's message of "Thu, 09 Jul 2026 10:41:40 +0800")

Chen Linxuan via B4 Relay <devnull+me.black-desk.cn@kernel.org>
writes:

> The `includeIf` mechanism already supports matching on the `.git`
> directory path (`gitdir`) and the currently checked out branch
> (`onbranch`).  But in multi-worktree setups the `.git` directory of a
> linked worktree points into the main repository's `.git/worktrees/`
> area, which makes `gitdir` patterns cumbersome when one wants to
> include config based on the working tree's checkout path instead.

Thanks.

This seems to break t1305 when merged to 'seen', even though all of
them pass standalone.  I did not have time to figure out what
interactions with which other topic are causing the breakages.

  parent reply	other threads:[~2026-07-09 20:40 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-09  2:41 [PATCH v7 0/3] includeIf: add "worktree" condition for matching working tree path Chen Linxuan
2026-07-09  2:41 ` Chen Linxuan via B4 Relay
2026-07-09  2:41 ` [PATCH v7 1/3] config: refactor include_by_gitdir() into include_by_path() Chen Linxuan
2026-07-09  2:41   ` Chen Linxuan via B4 Relay
2026-07-09  2:41 ` [PATCH v7 2/3] repository: keep a symlink-preserving copy of the worktree path Chen Linxuan
2026-07-09  2:41   ` Chen Linxuan via B4 Relay
2026-07-09 10:09   ` Patrick Steinhardt
2026-07-09  2:41 ` [PATCH v7 3/3] config: add "worktree" and "worktree/i" includeIf conditions Chen Linxuan
2026-07-09  2:41   ` Chen Linxuan via B4 Relay
2026-07-09 10:09 ` [PATCH v7 0/3] includeIf: add "worktree" condition for matching working tree path Patrick Steinhardt
2026-07-09 20:40 ` Junio C Hamano [this message]
2026-07-10  6:43 ` [PATCH v8 0/2] " Chen Linxuan
2026-07-10  6:43   ` Chen Linxuan via B4 Relay
2026-07-10  6:43   ` [PATCH v8 1/2] config: refactor include_by_gitdir() into include_by_path() Chen Linxuan
2026-07-10  6:43     ` Chen Linxuan via B4 Relay
2026-07-10  6:43   ` [PATCH v8 2/2] config: add "worktree" and "worktree/i" includeIf conditions Chen Linxuan
2026-07-10  6:43     ` Chen Linxuan via B4 Relay
2026-07-13 11:16     ` Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqzezzkibu.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=devnull+me.black-desk.cn@kernel.org \
    --cc=git@vger.kernel.org \
    --cc=kristofferhaugsbakk@fastmail.com \
    --cc=me@black-desk.cn \
    --cc=phillip.wood@dunelm.org.uk \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.