All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org,  Jeff King <peff@peff.net>,
	 Taylor Blau <me@ttaylorr.com>
Subject: Re: [PATCH 1/2] t5530: modernize tests
Date: Wed, 03 Sep 2025 21:10:00 -0700	[thread overview]
Message-ID: <xmqqzfbac0yv.fsf@gitster.g> (raw)
In-Reply-To: <20250903-b4-pks-upload-pack-repeated-non-commit-acks-v1-1-4e019af4dddc@pks.im> (Patrick Steinhardt's message of "Wed, 03 Sep 2025 06:54:10 +0200")

Patrick Steinhardt <ps@pks.im> writes:

> -D=$(pwd)
> -
> @@ -21,11 +19,7 @@ test_expect_success 'setup and corrupt repository' '
>  	test_tick &&
>  	echo changed >file &&
>  	git commit -a -m changed &&
> -	corrupt_repo HEAD:file
> -
> -'
> -
> -test_expect_success 'fsck fails' '
> +	corrupt_repo HEAD:file &&
>  	test_must_fail git fsck
>  '
>  
> @@ -40,17 +34,12 @@ test_expect_success 'upload-pack fails due to error in pack-objects packing' '
>  '
>  
>  test_expect_success 'corrupt repo differently' '
> -
>  	git hash-object -w file &&
> -	corrupt_repo HEAD^^{tree}
> -
> -'
> -
> -test_expect_success 'fsck fails' '
> +	corrupt_repo HEAD^^{tree} &&
>  	test_must_fail git fsck
>  '

Both changes make sense.

> -test_expect_success 'create empty repository' '
> -
> -	mkdir foo &&
> -	cd foo &&
> -	git init
> -
> -'
> -
>  test_expect_success 'fetch fails' '
> -
> -	test_must_fail git fetch .. main
> -
> +	git init foo &&
> +	test_must_fail git -C foo fetch .. main
>  '

Nice.

  reply	other threads:[~2025-09-04  4:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-03  4:54 [PATCH 0/2] upload-pack: don't ACK non-commits repeatedly Patrick Steinhardt
2025-09-03  4:54 ` [PATCH 1/2] t5530: modernize tests Patrick Steinhardt
2025-09-04  4:10   ` Junio C Hamano [this message]
2025-09-03  4:54 ` [PATCH 2/2] upload-pack: don't ACK non-commits repeatedly in protocol v2 Patrick Steinhardt
2025-09-04  4:23   ` Junio C Hamano
2025-09-04 12:42     ` Patrick Steinhardt
2025-09-04 16:37       ` Junio C Hamano
2025-09-05  6:11         ` Patrick Steinhardt
2025-09-05  6:18 ` [PATCH v2 0/2] upload-pack: don't ACK non-commits repeatedly Patrick Steinhardt
2025-09-05  6:18   ` [PATCH v2 1/2] t5530: modernize tests Patrick Steinhardt
2025-09-05  6:18   ` [PATCH v2 2/2] upload-pack: don't ACK non-commits repeatedly in protocol v2 Patrick Steinhardt
2025-09-08 16:51     ` Jeff King
2025-09-05 21:39   ` [PATCH v2 0/2] upload-pack: don't ACK non-commits repeatedly Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqzfbac0yv.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=me@ttaylorr.com \
    --cc=peff@peff.net \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.