All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Aditya Garg <gargaditya08@live.com>
Cc: git@vger.kernel.org,  M Hickford <mirth.hickford@gmail.com>,
	 Julian Swagemakers <julian@swagemakers.org>,
	 Eric Sunshine <sunshine@sunshineco.com>,
	 sandals@crustytoothpaste.net,  Zi Yao <ziyao@disroot.org>,
	 Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Subject: Re: [PATCH v7 0/3] Improve checks for valid_fqdn in send-email and update documentation
Date: Thu, 08 May 2025 11:08:44 -0700	[thread overview]
Message-ID: <xmqqzffn561f.fsf@gitster.g> (raw)
In-Reply-To: <PN0PR01MB95882173451A6A7C28AD7BE7B88BA@PN0PR01MB9588.INDPRD01.PROD.OUTLOOK.COM> (Aditya Garg's message of "Thu, 8 May 2025 17:14:26 +0000")

Aditya Garg <gargaditya08@live.com> writes:

> Hi all
>
> This series of patches mainly has two changes:
>
> 1. Improve the checks for valid_fqdn in send-email to be more strict and
>    compliant with RFC1035.
> 2. Update the documentation for send-email to include examples of using
>    OAuth2.0 with Gmail and Outlook, as well as links to the credential
>    helpers for these services.
>
> P.S. I have used `git-credential-outlook` linked in the second and third
> patch for this email!
>
> v2: - Improve grammar and add missing "" in second patch.
>     - Separate footnotes and the trailer block with a blank line in the first
>       patch.
>
> v3: - Change link for email helpers since old one was too long.
>
> v4: - Improve log message of first and second patch.
>     - Update valid_fqdn check in first patch to allow one or more <upto 63
>       octet run of alnum or hyphen that does not begin or end with hyphen>,
>       separated by a single dot in between each.
>     - Revert the documentation regarding sending patches to a mailing list
>       in the second patch.
>
> v5: - Simplify the regex in the first patch to check for valid FQDN.
>     - Fix formatting in the second patch to make it more readable.
>
> v6: - Use backticks for ~/.gitconfig in the second patch.
>
> v7: - Clarify the use of `OAUTHBEARER` and `XOAUTH2` in the second patch.

Much better than what I came up with ;-)  Nicely phrased.

Will queue.  Unless there are issues pointed out by others in a few
days, let me mark the topic for 'next'.

Thanks.

  parent reply	other threads:[~2025-05-08 18:08 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-04 13:54 [PATCH 0/3] Improve checks for valid_fqdn in send-email and update documentation Aditya Garg
2025-05-04 13:54 ` [PATCH 1/3] send-mail: improve checks for valid_fqdn Aditya Garg
2025-05-04 14:22   ` Kristoffer Haugsbakk
2025-05-04 15:26     ` Aditya Garg
2025-05-04 16:05       ` Kristoffer Haugsbakk
2025-05-04 13:54 ` [PATCH 2/3] docs: improve send-email documentation Aditya Garg
2025-05-04 13:54 ` [PATCH 3/3] docs: add credential helper for outlook and gmail in OAuth list of helpers Aditya Garg
2025-05-05  6:16 ` [PATCH v2 0/3] Improve checks for valid_fqdn in send-email and update documentation Aditya Garg
2025-05-05  6:16   ` [PATCH v2 1/3] send-mail: improve checks for valid_fqdn Aditya Garg
2025-05-05  6:16   ` [PATCH v2 2/3] docs: improve send-email documentation Aditya Garg
2025-05-05 19:20     ` Junio C Hamano
2025-05-05 19:30       ` Aditya Garg
2025-05-05  6:16   ` [PATCH v2 3/3] docs: add credential helper for outlook and gmail in OAuth list of helpers Aditya Garg
2025-05-05 15:23 ` [PATCH v3 0/3] Improve checks for valid_fqdn in send-email and update documentation Aditya Garg
2025-05-05 15:23   ` [PATCH v3 1/3] send-mail: improve checks for valid_fqdn Aditya Garg
2025-05-05 23:49     ` Junio C Hamano
2025-05-06  5:38       ` Aditya Garg
2025-05-06  9:35         ` Aditya Garg
2025-05-06 16:50           ` Aditya Garg
2025-05-06 21:59             ` Junio C Hamano
2025-05-06 17:11           ` Junio C Hamano
2025-05-06 17:23             ` Aditya Garg
2025-05-06 17:49               ` Aditya Garg
2025-05-06 22:07               ` Junio C Hamano
2025-05-05 15:23   ` [PATCH v3 2/3] docs: improve send-email documentation Aditya Garg
2025-05-05 23:54     ` Junio C Hamano
2025-05-06  5:36       ` Aditya Garg
2025-05-05 15:23   ` [PATCH v3 3/3] docs: add credential helper for outlook and gmail in OAuth list of helpers Aditya Garg
2025-05-07 12:33 ` [PATCH v4 0/3] Improve checks for valid_fqdn in send-email and update documentation Aditya Garg
2025-05-07 12:33   ` [PATCH v4 1/3] send-mail: improve checks for valid_fqdn Aditya Garg
2025-05-07 12:48     ` Aditya Garg
2025-05-07 22:42     ` Junio C Hamano
2025-05-08 10:38       ` Aditya Garg
2025-05-07 12:33   ` [PATCH v4 2/3] docs: improve send-email documentation Aditya Garg
2025-05-07 22:21     ` Junio C Hamano
2025-05-08  3:29       ` Aditya Garg
2025-05-08 13:33         ` Junio C Hamano
2025-05-08 13:52           ` Aditya Garg
2025-05-08 16:23             ` Junio C Hamano
2025-05-08 16:38               ` Aditya Garg
2025-05-08 14:52           ` Junio C Hamano
2025-05-08 15:05             ` Aditya Garg
2025-05-08 15:08               ` Aditya Garg
2025-05-07 12:33   ` [PATCH v4 3/3] docs: add credential helper for outlook and gmail in OAuth list of helpers Aditya Garg
2025-05-08 15:18 ` [PATCH v6 0/3] Improve checks for valid_fqdn in send-email and update documentation Aditya Garg
2025-05-08 15:18   ` [PATCH v6 1/3] send-mail: improve checks for valid_fqdn Aditya Garg
2025-05-08 15:18   ` [PATCH v6 2/3] docs: improve send-email documentation Aditya Garg
2025-05-08 15:18   ` [PATCH v6 3/3] docs: add credential helper for outlook and gmail in OAuth list of helpers Aditya Garg
2025-05-08 17:14 ` [PATCH v7 0/3] Improve checks for valid_fqdn in send-email and update documentation Aditya Garg
2025-05-08 17:14   ` [PATCH v7 1/3] send-mail: improve checks for valid_fqdn Aditya Garg
2025-05-08 17:14   ` [PATCH v7 2/3] docs: improve send-email documentation Aditya Garg
2025-05-08 17:14   ` [PATCH v7 3/3] docs: add credential helper for outlook and gmail in OAuth list of helpers Aditya Garg
2025-05-08 18:08   ` Junio C Hamano [this message]
2025-05-09 16:49   ` [PATCH] send-email: try to get fqdn by running hostname --fqdn on Linux and macOS Aditya Garg
2025-05-09 20:13     ` Junio C Hamano
2025-05-10  7:37     ` [PATCH v2] " Aditya Garg
2025-05-12  7:46       ` Julian Swagemakers
2025-05-12  7:49         ` Aditya Garg
2025-05-12 16:42         ` Junio C Hamano
2025-05-12 16:46           ` Aditya Garg
2025-05-12 17:34             ` Junio C Hamano
2025-05-12 17:42               ` Aditya Garg
2025-05-12 19:05               ` Eric Sunshine
2025-05-12 20:15                 ` Junio C Hamano
2025-05-13 12:28                   ` Aditya Garg
2025-05-12 13:32       ` Junio C Hamano
2025-05-12  8:11     ` [PATCH v3] send-email: try to get fqdn by running hostname -f " Aditya Garg
2025-05-12 17:16     ` [PATCH v4] " Aditya Garg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqzffn561f.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=gargaditya08@live.com \
    --cc=git@vger.kernel.org \
    --cc=julian@swagemakers.org \
    --cc=kristofferhaugsbakk@fastmail.com \
    --cc=mirth.hickford@gmail.com \
    --cc=sandals@crustytoothpaste.net \
    --cc=sunshine@sunshineco.com \
    --cc=ziyao@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.