From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Patrick Steinhardt <ps@pks.im>,
Johannes Schindelin <johannes.schindelin@gmx.de>,
Taylor Blau <me@ttaylorr.com>
Subject: Re: [PATCH] perf: do allow `GIT_PERF_*` to be overridden again
Date: Tue, 22 Apr 2025 08:37:02 -0700 [thread overview]
Message-ID: <xmqqzfg8438h.fsf@gitster.g> (raw)
In-Reply-To: <20250422104125.GA1460472@coredump.intra.peff.net> (Jeff King's message of "Tue, 22 Apr 2025 06:41:25 -0400")
Jeff King <peff@peff.net> writes:
> The original patch in this thread did something like:
>
> git_perf_settings=$(...pull GIT_PERF_* from env...)
> . ../test-lib.sh
> eval "$git_perf_settings"
>
> That is, we stash away the environment, then load test-lib.sh, which
> overwrites the environment, and then we restore (some of) the original
> values.
>
> In that merge, the test-lib.sh inclusion is moved (and in fact is now
> accompanied by an explicit inclusion of GIT-BUILD-OPTIONS), and we now
> have:
>
> . "$GIT_BUILD_DIR"/GIT-BUILD-OPTIONS
> . "$GIT_SOURCE_DIR"/t/test-lib.sh
> git_perf_settings=$(...)
> eval "$git_perf_settings"
>
> Which of course does nothing. We need to set $git_perf_settings before
> those other source lines (and the eval must remain after them).
Right. Thanks.
prev parent reply other threads:[~2025-04-22 15:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-04 10:56 [PATCH] perf: do allow `GIT_PERF_*` to be overridden again Johannes Schindelin via GitGitGadget
2025-04-04 12:13 ` Derrick Stolee
2025-04-19 3:54 ` Jeff King
2025-04-20 21:12 ` Junio C Hamano
2025-04-22 10:41 ` Jeff King
2025-04-22 15:37 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzfg8438h.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=johannes.schindelin@gmx.de \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.