All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jan Palus <jpalus@fastmail.com>
Cc: Patrick Steinhardt <ps@pks.im>,  git@vger.kernel.org
Subject: Re: [PATCH] t8002-blame: simplify padding generation in blank boundary tests
Date: Tue, 21 Jan 2025 12:10:37 -0800	[thread overview]
Message-ID: <xmqqzfjkylky.fsf@gitster.g> (raw)
In-Reply-To: <bwo4w2qbbe6czt4n7vshwyn4lbl2ieihqmdugz4fmnhd4qbsd2@tevhcjwigxbi> (Jan Palus's message of "Mon, 20 Jan 2025 11:47:56 +0100")

Jan Palus <jpalus@fastmail.com> writes:

> Note that original version was "%0.s" in which there is some ambiguity
> whether "0" is a flag or field width and not "%.0s" in which "0" indeed
> would mean precision.

Ah, I missed that part.  Also thanks for filling in the "printf from
coreutils is the one that has issues with the code".

>> Anybody can help that "further polishing as suggested" step, and
>> when the patch is left in limbo for too long, I might step in to do
>> it myself (when I have no other better things to do), but it is
>> customary around here that the original patch submitter does so.
>
> I was about to follow-up but didn't find time. Sorry it took so long.
> I will post v2 shortly.

Thanks.

      reply	other threads:[~2025-01-21 20:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-11 23:11 [PATCH] t8002-blame: simplify padding generation in blank boundary tests Jan Palus
2025-01-13 12:36 ` Patrick Steinhardt
2025-01-13 15:15   ` Junio C Hamano
2025-01-18  1:09     ` Junio C Hamano
2025-01-20 10:47       ` Jan Palus
2025-01-21 20:10         ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqzfjkylky.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jpalus@fastmail.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.