From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, phillip.wood@dunelm.org.uk,
"Rubén Justo" <rjusto@gmail.com>
Subject: Re: [PATCH 1/2] am: add explicit "--retry" option
Date: Thu, 06 Jun 2024 09:38:45 -0700 [thread overview]
Message-ID: <xmqqzfrym3fu.fsf@gitster.g> (raw)
In-Reply-To: <20240606082114.GA1167215@coredump.intra.peff.net> (Jeff King's message of "Thu, 6 Jun 2024 04:21:14 -0400")
Jeff King <peff@peff.net> writes:
> I think even without the test-terminal cleanup, this is a good thing.
> Any time there is a heuristic like isatty(), we should have a way for
> the user to be more explicit about what they want().
I very often do "git am --no-3" to countermand a failed "git am -3"
(or vice versa), so I'll be hit very hard with a need to retrain my
fingers. But I'll live ;-)
"--retry" is a horrible word, in that it makes it sound like it will
keep trying to apply the same patch over and over until it applies
cleanly or something. Can't we use "--continue" like everybody else
(like "git rebase --continue", etc.), or would that be even more
confusing?
next prev parent reply other threads:[~2024-06-06 16:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 8:17 [PATCH 0/2] dropping stdin support from test-terminal Jeff King
2024-06-06 8:21 ` [PATCH 1/2] am: add explicit "--retry" option Jeff King
2024-06-06 16:38 ` Junio C Hamano [this message]
2024-06-06 16:48 ` Junio C Hamano
2024-06-08 11:29 ` Jeff King
2024-06-10 8:36 ` Phillip Wood
2024-06-06 8:22 ` [PATCH 2/2] test-terminal: drop stdin handling Jeff King
2024-06-06 16:14 ` Rubén Justo
2024-06-06 16:17 ` [PATCH 0/2] dropping stdin support from test-terminal Rubén Justo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzfrym3fu.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=phillip.wood@dunelm.org.uk \
--cc=rjusto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.