All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "D. Ben Knoble via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,
	 Felipe Contreras <felipe.contreras@gmail.com>,
	"D. Ben Knoble" <ben.knoble+github@gmail.com>
Subject: Re: [PATCH] completion: zsh: stop leaking local cache variable
Date: Tue, 30 Apr 2024 16:18:49 -0700	[thread overview]
Message-ID: <xmqqzftawiau.fsf@gitster.g> (raw)
In-Reply-To: <pull.1725.git.1714513995564.gitgitgadget@gmail.com> (D. Ben Knoble via GitGitGadget's message of "Tue, 30 Apr 2024 21:53:15 +0000")

"D. Ben Knoble via GitGitGadget" <gitgitgadget@gmail.com> writes:

> Commit beb6ee7163 (completion: extract repository discovery from
> __gitdir(), 2017-02-03) anticipated this problem by marking
> __git_repo_path as local in __git_main and __gitk_main for Bash
> completion but did not give the same mark to _git for Zsh completion.
> Thus make __git_repo_path local for Zsh completion, too.

Will queue.  The explanation makes tons of sense.

Thanks.

      reply	other threads:[~2024-04-30 23:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-30 21:53 [PATCH] completion: zsh: stop leaking local cache variable D. Ben Knoble via GitGitGadget
2024-04-30 23:18 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqzftawiau.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=ben.knoble+github@gmail.com \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.