From: Junio C Hamano <gitster@pobox.com>
To: Phillip Wood <phillip.wood123@gmail.com>
Cc: Eric Sunshine <sunshine@sunshineco.com>,
emilyshaffer@google.com, git@vger.kernel.org,
Emily Shaffer <nasamuffin@google.com>,
Sheik <sahibzone@gmail.com>, Dragan Simic <dsimic@manjaro.org>
Subject: Re: [PATCH v3] bugreport: reject positional arguments
Date: Tue, 31 Oct 2023 11:17:26 +0900 [thread overview]
Message-ID: <xmqqzfzz5ydl.fsf@gitster.g> (raw)
In-Reply-To: <xmqqfs1radrj.fsf@gitster.g> (Junio C. Hamano's message of "Tue, 31 Oct 2023 08:31:28 +0900")
Junio C Hamano <gitster@pobox.com> writes:
> Phillip Wood <phillip.wood123@gmail.com> writes:
>
>> ... it is determining that grep
>> failed in the first place that I find annoying. I've also found the
>> output from test_i18ngrep is helpful when debugging CI test failures.
>
> Thanks, I agree with you that it is very useful for debugging to
> have an explicit "I did not find what I expected to see". On the
> other hand, the other side is not as severe a problem, I think. If
> "grep" expects not to see an error message in the output but the
> output has the error we do not want to see, we will see the message
> in the "-v" output when we run test.
Everything I wrote above makes sense, but what I continued this
message with (below---omitted) is total opposite. Let's discard and
maybe retry sometime later.
next prev parent reply other threads:[~2023-10-31 2:17 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 20:59 git bugreport with invalid CLI argument does not report error Sheik
2023-10-25 22:53 ` Emily Shaffer
2023-10-25 23:11 ` Eric Sunshine
2023-10-26 0:55 ` [PATCH v2] bugreport: reject positional arguments emilyshaffer
2023-10-26 3:43 ` Eric Sunshine
2023-10-26 3:52 ` Dragan Simic
2023-10-26 4:03 ` Eric Sunshine
2023-10-26 4:06 ` Dragan Simic
2023-10-26 15:54 ` [PATCH v3] " emilyshaffer
2023-10-26 17:18 ` Eric Sunshine
2023-10-27 14:41 ` Phillip Wood
2023-10-30 0:15 ` Junio C Hamano
2023-10-30 0:26 ` Junio C Hamano
2023-10-30 0:33 ` Junio C Hamano
2023-10-30 1:59 ` Junio C Hamano
2023-10-30 14:11 ` Phillip Wood
2023-10-30 23:31 ` Junio C Hamano
2023-10-31 2:17 ` Junio C Hamano [this message]
2023-10-31 5:23 ` [PATCH 0/2] Deprecate test_i18ngrep further Junio C Hamano
2023-10-31 5:23 ` [PATCH 1/2] test framework: further deprecate test_i18ngrep Junio C Hamano
2023-10-31 5:23 ` [PATCH 2/2] tests: teach callers of test_i18ngrep to use test_grep Junio C Hamano
2023-11-01 14:44 ` Phillip Wood
2023-11-01 23:19 ` Junio C Hamano
2023-10-26 18:22 ` [PATCH v4 0/2] bugreport: reject positional arguments emilyshaffer
2023-10-26 20:13 ` Eric Sunshine
2023-10-26 18:22 ` [PATCH v4 1/2] t0091-bugreport: stop using i18ngrep emilyshaffer
2023-10-29 23:59 ` Junio C Hamano
2023-10-26 18:22 ` [PATCH v4 2/2] bugreport: reject positional arguments emilyshaffer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzfzz5ydl.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=dsimic@manjaro.org \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=nasamuffin@google.com \
--cc=phillip.wood123@gmail.com \
--cc=sahibzone@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.