All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Felipe Contreras <felipe.contreras@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] doc: doc-diff: specify date
Date: Thu, 04 May 2023 22:55:52 -0700	[thread overview]
Message-ID: <xmqqzg6jgw47.fsf@gitster.g> (raw)
In-Reply-To: <20230505014610.GA2366370@coredump.intra.peff.net> (Jeff King's message of "Thu, 4 May 2023 21:46:10 -0400")

Jeff King <peff@peff.net> writes:

>> >  			GIT_VERSION=omitted \
>> > +			GIT_DATE=1970-01-01 \
>> >  			SOURCE_DATE_EPOCH=0 \
>> >  			DESTDIR="$tmp/installed/$dname+" \
>> >  			install-man &&
>> 
>> I wonder what the existing SOURCE_DATE_EPOCH was trying to do there,
>> though.
>
> It used to be necessary so that we had a reproducible build. Otherwise,
> asciidoc uses the mtime of the file, and diffing two versions would have
> tons of uninteresting date-differences.
>
> After 28fde3a1 I doubt it is necessary, as the header uses $GIT_DATE
> instead (it's possible the mtime may be used elsewhere, but I didn't see
> any spot after grepping a built xml file. And at any rate, if it does
> not produce a visible difference, that is enough for doc-diff).

Thanks for confirming my suspicion.  I guess leaving it there still
would not hurt.  It can be removed whenever somebody motivated
enough comes and shows a well-reasoned patch that explains why it no
longer is necessary ;-)


  reply	other threads:[~2023-05-05  5:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-03 23:23 [PATCH] doc: doc-diff: specify date Felipe Contreras
2023-05-05  1:15 ` Junio C Hamano
2023-05-05  1:46   ` Jeff King
2023-05-05  5:55     ` Junio C Hamano [this message]
2023-05-05 21:16       ` Jeff King
2023-05-08  2:08   ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqzg6jgw47.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.