From: Junio C Hamano <gitster@pobox.com>
To: "Martin Ågren" <martin.agren@gmail.com>
Cc: git@vger.kernel.org, Siddharth Asthana <siddharthasthana31@gmail.com>
Subject: Re: [PATCH] git-cat-file.txt: fix list continuations rendering literally
Date: Wed, 18 Jan 2023 08:23:48 -0800 [thread overview]
Message-ID: <xmqqzgaf4xrf.fsf@gitster.g> (raw)
In-Reply-To: <20230118082749.1252459-1-martin.agren@gmail.com> ("Martin Ågren"'s message of "Wed, 18 Jan 2023 09:27:49 +0100")
Martin Ågren <martin.agren@gmail.com> writes:
> With Asciidoctor, all of the '+' introduced in a797c0ea04 ("cat-file:
> add mailmap support to --batch-check option", 2022-12-20) render
> literally rather than functioning as list continuations. With asciidoc,
> this renders just fine.
Good to have somebody who is careful to notice these differences ;-)
> For consistency, let's wrap all three of these inner lists from
> a797c0ea04 in open blocks. This also future-proofs us a little -- if we
> ever gain more contents after any of those first two lists, as we did
> already in a797c0ea04 for the third list, we're prepared and should
> render fine with both asciidoc and Asciidoctor from the start.
Nice.
Are you comparing both roff output and html output, by the way?
Thanks.
next prev parent reply other threads:[~2023-01-18 16:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 8:27 [PATCH] git-cat-file.txt: fix list continuations rendering literally Martin Ågren
2023-01-18 16:23 ` Junio C Hamano [this message]
2023-01-19 8:04 ` Martin Ågren
2023-01-19 16:24 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzgaf4xrf.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=martin.agren@gmail.com \
--cc=siddharthasthana31@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.