All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Cleber Rosa via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Cleber Rosa <crosa@redhat.com>
Subject: Re: [PATCH] setup: fix function name
Date: Fri, 17 Jun 2022 15:43:45 -0700	[thread overview]
Message-ID: <xmqqzgianc66.fsf@gitster.g> (raw)
In-Reply-To: <pull.1255.git.1654782920256.gitgitgadget@gmail.com> (Cleber Rosa via GitGitGadget's message of "Thu, 09 Jun 2022 13:55:20 +0000")

"Cleber Rosa via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Cleber Rosa <crosa@redhat.com>
> Subject: Re: [PATCH] setup: fix function name

I'd add "in a BUG() message" at the end.

> diff --git a/setup.c b/setup.c
> index faf5095e44d..b5a537258d2 100644
> --- a/setup.c
> +++ b/setup.c
> @@ -1402,7 +1402,7 @@ const char *setup_git_directory_gently(int *nongit_ok)
>  		 * find a repository.
>  		 */
>  	default:
> -		BUG("unhandled setup_git_directory_1() result");
> +		BUG("unhandled setup_git_directory_gently_1() result");
>  	}

Did you actually hit this BUG() and was sent to a wild goose chase
because of this typo?  Just checking, because BUG() that triggers
is a more serious issue itself.

Thanks.

      reply	other threads:[~2022-06-17 22:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-09 13:55 [PATCH] setup: fix function name Cleber Rosa via GitGitGadget
2022-06-17 22:43 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqzgianc66.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=crosa@redhat.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.