All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] Documentation/Makefile: fix lint-docs mkdir dependency
Date: Thu, 28 Oct 2021 09:45:14 -0700	[thread overview]
Message-ID: <xmqqzgqtrtd1.fsf@gitster.g> (raw)
In-Reply-To: <YXq1OE/p5VoPR3WZ@coredump.intra.peff.net> (Jeff King's message of "Thu, 28 Oct 2021 10:35:36 -0400")

Jeff King <peff@peff.net> writes:

> There's an in-between, I'd think, where the many "foo/bar/baz/$@"
> targets have an order-dependency on "foo/bar/baz", and that single rule
> uses "mkdir -p" to create all of the directories.
>
> It doesn't buy us much simplification in this case, though, because
> various rules independently depend on .build/gitlink/lint-docs/howto,
> .built/gitlink/lint-docs, and .build/gitlink, etc. So we still end up
> with roughly the same number of rules, though the directory rules don't
> have to depend on one another.
>
> It also means that these "mkdir -p" may race with each other, though in
> general I'd hope that most "mkdir" implements could handle this.
>
> Something like this works, I think:

Hmph, what I actually meant was to make sure that the recipe to
create the files to have "mkdir -p $(basename $@)" in front, instead
of having "we need to prepare the containing directory in order to
have a file there" in the makefile.

> ...
> At any rate, I don't think there's any urgency on that.

Sure.  I think I've picked up the one at the start of this thread
already, so we should be good.

Thanks.

  reply	other threads:[~2021-10-28 16:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-26  7:31 [PATCH] Documentation/Makefile: fix lint-docs mkdir dependency Jeff King
2021-10-26 10:05 ` Ævar Arnfjörð Bjarmason
2021-10-26 21:18   ` Jeff King
2021-10-28  0:03 ` Junio C Hamano
2021-10-28  7:48   ` Ævar Arnfjörð Bjarmason
2021-10-28 14:35     ` Jeff King
2021-10-28 16:45       ` Junio C Hamano [this message]
2021-10-28 17:06         ` Jeff King
2021-10-28 18:30           ` Ævar Arnfjörð Bjarmason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqzgqtrtd1.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.