From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>
Subject: Re: [PATCH] string-list.[ch]: remove string_list_init() compatibility function
Date: Tue, 28 Sep 2021 14:43:08 -0700 [thread overview]
Message-ID: <xmqqzgrwidg3.fsf@gitster.g> (raw)
In-Reply-To: <patch-1.1-03c805dd90f-20210928T124939Z-avarab@gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Tue, 28 Sep 2021 14:49:45 +0200")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> Remove this function left over to accommodate in-flight changes, see
> 770fedaf9fb (string-list.[ch]: add a string_list_init_{nodup,dup}(),
> 2021-07-01) for the recent change to add
> "string_list_init_{nodup,dup}()" initializers.
>
> There was only one user of the API left in remote-curl.c. I don't know
> why I didn't include this change to remote-curl.c in
> bc40dfb10a0 (string-list.h users: change to use *_{nodup,dup}(),
> 2021-07-01), perhaps I just missed it.
>
> In any case, let's change that one user to use the new API, as of
> writing this there are no in-flight changes that use, so this seems
> like a good time to drop this before we get any new users of this
> compatibility API.
>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
Thanks.
prev parent reply other threads:[~2021-09-28 21:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 12:49 [PATCH] string-list.[ch]: remove string_list_init() compatibility function Ævar Arnfjörð Bjarmason
2021-09-28 18:00 ` Jeff King
2021-09-28 21:43 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzgrwidg3.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.