All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
	Dan Jacques <dnj@google.com>,
	Alex Riesen <alexander.riesen@cetitec.com>,
	Jonathan Nieder <jrnieder@gmail.com>,
	Brandon Casey <drafnel@gmail.com>, Petr Baudis <pasky@ucw.cz>,
	Gerrit Pape <pape@smarden.org>,
	"martin f . krafft" <madduck@madduck.net>,
	Eric Wong <e@80x24.org>
Subject: Re: [PATCH v2] Makefile: replace perl/Makefile.PL with simple make rules
Date: Mon, 04 Dec 2017 08:22:54 -0800	[thread overview]
Message-ID: <xmqqzi6ympi9.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20171203115941.16674-1-avarab@gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Sun, 3 Dec 2017 11:59:41 +0000")

I did this immediately after applying; please double check.

Thanks.

1: da337670f5 ! 1: aeae85bdd0 Makefile: replace perl/Makefile.PL with simple make rules
    @@ -27,7 +27,7 @@
         So replace the whole thing with something that's pretty much a copy of
         how we generate po/build/**.mo from po/*.po, just with a small sed(1)
         command instead of msgfmt. As that's being done rename the files
    -    from *.pm to *.pmc just to indicate that they're genreated (see
    +    from *.pm to *.pmc just to indicate that they're generated (see
         "perldoc -f require").

         While I'm at it, change the fallback for Error.pm from being something
    @@ -50,9 +50,9 @@
            it could be set in addition to INSTLIBDIR, but my reading of [7] is
            that this is the desired behavior.

    -     * We don't man pages for all of the perl modules as we used t, only
    -       Git(3pm). As discussed on-list[8] that we were building installed
    -       manpages for purely internal APIs like Git::I18N or
    +     * We don't build man pages for all of the perl modules as we used to,
    +       only Git(3pm). As discussed on-list[8] that we were building
    +       installed manpages for purely internal APIs like Git::I18N or
            private-Error.pm was always a bug anyway, and all the Git::SVN::*
            ones say they're internal APIs.

:

  reply	other threads:[~2017-12-04 16:23 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-29 15:34 [RFC/PATCH] Makefile: replace the overly complex perl build system with something simple Ævar Arnfjörð Bjarmason
2017-11-29 19:54 ` [PATCH] Makefile: replace perl/Makefile.PL with simple make rules Ævar Arnfjörð Bjarmason
2017-11-30  2:11   ` Jonathan Nieder
2017-11-30  9:37     ` Ævar Arnfjörð Bjarmason
2017-11-30 20:59       ` Jonathan Nieder
2017-11-30 21:16         ` Eric Wong
2017-11-30 21:31   ` Jeff King
2017-11-30 22:30     ` Ævar Arnfjörð Bjarmason
2017-12-21 19:29     ` Alex Vandiver
2017-12-03 11:59   ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2017-12-04 16:22     ` Junio C Hamano [this message]
2017-12-04 18:08       ` Ævar Arnfjörð Bjarmason
2017-12-04 19:42         ` Junio C Hamano
2017-12-04 19:51           ` Dan Jacques
2017-12-10 21:13   ` [PATCH v3] " Ævar Arnfjörð Bjarmason
2017-12-11 23:29     ` Junio C Hamano
2017-12-12 21:33     ` Randall S. Becker
2017-12-12 22:26       ` Ævar Arnfjörð Bjarmason
2017-12-15 10:35         ` Michael J Gruber
2017-12-15 15:09           ` Todd Zullinger
2017-12-15 17:31           ` Ævar Arnfjörð Bjarmason
2017-12-19 15:53             ` Junio C Hamano
2017-12-19 23:57               ` [PATCH v4] " Ævar Arnfjörð Bjarmason
2017-12-20  6:15                 ` Todd Zullinger
2017-12-20 11:52                   ` [PATCH v5] " Ævar Arnfjörð Bjarmason
2017-12-20 17:41                     ` Todd Zullinger
2017-12-20 18:24                       ` [PATCH v6] " Ævar Arnfjörð Bjarmason
2017-12-20 20:17                         ` Todd Zullinger
2017-12-21  7:22                         ` Alex Riesen
2017-12-22 19:07                         ` Junio C Hamano
2017-12-27 22:24                           ` Ævar Arnfjörð Bjarmason
2017-12-28 18:36                             ` Junio C Hamano
2018-01-02 19:17                         ` Jonathan Nieder
2018-01-02 20:01                           ` [PATCH ab/simplify-perl-makefile] perl: treat PERLLIB_EXTRA as an extra path again (Re: [PATCH v6] Makefile: replace perl/Makefile.PL with simple make rules) Jonathan Nieder
2018-01-02 20:39                             ` Ævar Arnfjörð Bjarmason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqzi6ympi9.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=alexander.riesen@cetitec.com \
    --cc=avarab@gmail.com \
    --cc=dnj@google.com \
    --cc=drafnel@gmail.com \
    --cc=e@80x24.org \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=madduck@madduck.net \
    --cc=pape@smarden.org \
    --cc=pasky@ucw.cz \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.