From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: David Turner <dturner@twosigma.com>,
git@vger.kernel.org, spearce@spearce.org
Subject: Re: [PATCH] remote-curl: don't hang when a server dies before any output
Date: Tue, 15 Nov 2016 09:42:57 -0800 [thread overview]
Message-ID: <xmqqzil0tza6.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20161115035844.e6ehuy7uigqinbnv@sigill.intra.peff.net> (Jeff King's message of "Mon, 14 Nov 2016 22:58:44 -0500")
Jeff King <peff@peff.net> writes:
> On Mon, Nov 14, 2016 at 05:02:27PM -0800, Junio C Hamano wrote:
>
>> Jeff King <peff@peff.net> writes:
>>
>> > Actually, I take it back. I think it works for a single round of ref
>> > negotiation, but not for multiple. Enabling GIT_TEST_LONG=1 causes it to
>> > fail t5551.
>> >
>> > I think I've probably made a mis-assumption on exactly when in the HTTP
>> > protocol we will see a flush packet (and perhaps that is a sign that
>> > this protocol-snooping approach is not a good one).
>>
>> Hmph. I think I tried David's original under GIT_TEST_LONG and saw
>> it got stuck; could be the same issue, I guess.
>
> It works OK here. I think it is just that the test is really slow (by
> design).
Yeah, I think what I recalled was my old attempt to run the
follow-up "any SHA-1" patch without this one.
next prev parent reply other threads:[~2016-11-15 17:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 22:18 [PATCH] remote-curl: don't hang when a server dies before any output David Turner
2016-11-14 18:24 ` Jeff King
2016-11-14 19:40 ` Jeff King
2016-11-14 21:19 ` Junio C Hamano
2016-11-14 21:33 ` Jeff King
2016-11-14 23:25 ` David Turner
2016-11-14 23:48 ` Jeff King
2016-11-15 15:45 ` David Turner
2016-11-15 0:44 ` Jeff King
2016-11-15 1:02 ` Junio C Hamano
2016-11-15 3:58 ` Jeff King
2016-11-15 17:42 ` Junio C Hamano [this message]
2016-11-18 17:01 ` Jeff King
2016-11-18 17:04 ` David Turner
2016-11-18 17:08 ` Jeff King
2016-11-18 17:48 ` David Turner
2016-11-18 18:28 ` Junio C Hamano
2016-11-15 2:40 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzil0tza6.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=dturner@twosigma.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.