From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Duy Nguyen <pclouds@gmail.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Johannes Sixt <j6t@kdbg.org>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH/RFC] git.c: support "!!" aliases that do not move cwd
Date: Mon, 10 Oct 2016 10:52:26 -0700 [thread overview]
Message-ID: <xmqqzimcf5wl.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20161009205854.byq2wqgemtmwudfb@sigill.intra.peff.net> (Jeff King's message of "Sun, 9 Oct 2016 16:58:54 -0400")
Jeff King <peff@peff.net> writes:
> Having separate exec/shell boolean options just punts the overlap from
> the command key to those keys. If you have two mutually exclusive
> options, I think the best thing is a single option, like:
>
> type = <shell | exec | whatever>
>
> and then it is obvious that a second appearance of "type" overrides an
> earlier one, by our usual "last one wins" convention. As opposed to:
>
> shell = true
> exec = true
>
> where you have to understand the meaning of each option to know that
> "exec" overrides "shell".
Good.
Duy's "do we want to chdir or stay?" would be an orthogonal axis to
"what does the command line look like?" and "how is the command line
run?" so it adds one member to the "alias.<string>.*" family of
variables, I guess.
next prev parent reply other threads:[~2016-10-10 17:53 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 11:41 [PATCH/RFC] git.c: support "!!" aliases that do not move cwd Nguyễn Thái Ngọc Duy
2016-10-06 18:42 ` Junio C Hamano
2016-10-07 11:20 ` Johannes Schindelin
2016-10-07 12:27 ` Duy Nguyen
2016-10-07 12:47 ` Matthieu Moy
2016-10-07 13:07 ` Duy Nguyen
2016-10-07 14:12 ` Johannes Schindelin
2016-10-07 14:31 ` Matthieu Moy
2016-10-07 14:11 ` Johannes Schindelin
2016-10-07 14:20 ` Jeff King
2016-10-07 17:42 ` Johannes Sixt
2016-10-07 17:50 ` Jeff King
2016-10-08 8:36 ` Johannes Schindelin
2016-10-09 6:01 ` Jeff King
2016-10-09 6:08 ` Jeff King
2016-10-09 11:32 ` Duy Nguyen
2016-10-09 20:58 ` Jeff King
2016-10-10 17:52 ` Junio C Hamano [this message]
2016-10-10 18:21 ` Jeff King
2016-10-10 19:07 ` Junio C Hamano
2016-10-11 9:44 ` Johannes Schindelin
2016-10-11 10:53 ` Duy Nguyen
2016-10-11 11:28 ` Johannes Schindelin
2016-10-11 15:01 ` Jeff King
2016-10-26 13:23 ` Duy Nguyen
2016-10-26 16:08 ` Junio C Hamano
2016-10-07 13:31 ` Jakub Narębski
2016-10-07 14:19 ` Johannes Schindelin
2016-10-07 15:55 ` Jakub Narębski
2016-10-08 0:32 ` Duy Nguyen
2016-10-11 11:51 ` SZEDER Gábor
2016-10-11 13:24 ` Jakub Narębski
2016-10-06 19:00 ` Jeff King
2016-10-06 19:07 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzimcf5wl.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.