From: Junio C Hamano <gitster@pobox.com>
To: sorganov@gmail.com
Cc: git@vger.kernel.org
Subject: Re: [PATCH 6/6] Documentation/git-merge.txt: get rid of irrelevant references to git-pull
Date: Wed, 05 Oct 2016 11:57:43 -0700 [thread overview]
Message-ID: <xmqqzimioc7s.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <b91ef5e97c60a85cce1a13f88a19218fd0f05655.1475678515.git.sorganov@gmail.com> (sorganov@gmail.com's message of "Wed, 5 Oct 2016 17:46:24 +0300")
sorganov@gmail.com writes:
> diff --git a/Documentation/git-merge.txt b/Documentation/git-merge.txt
> index 351b8fc..ba5fb0a 100644
> --- a/Documentation/git-merge.txt
> +++ b/Documentation/git-merge.txt
> @@ -23,10 +23,6 @@ named commits and the current branch, called "merge base", is
> calculated, and then net changes taken from the merge base to
> the named commits are applied.
>
> -This command is used by 'git pull' to incorporate changes from another
> -repository, and can be used by hand to merge changes from one branch
> -into another.
> -
Good.
> @@ -119,18 +115,17 @@ of `git fetch` for merging are merged to the current branch.
> PRE-MERGE CHECKS
> ----------------
>
> -Before applying outside changes, you should get your own work in
> -good shape and committed locally, so it will not be clobbered if
> -there are conflicts. See also linkgit:git-stash[1].
> -'git pull' and 'git merge' will stop without doing anything when
> -local uncommitted changes overlap with files that 'git pull'/'git
> -merge' may need to update.
> +Before applying outside changes, you should get your own work in good
> +shape and committed locally, so it will not be clobbered if there are
> +conflicts. See also linkgit:git-stash[1]. 'git merge' will stop
> +without doing anything when local uncommitted changes overlap with
> +files that 'git merge' may need to update.
>
> -To avoid recording unrelated changes in the merge commit,
> -'git pull' and 'git merge' will also abort if there are any changes
> -registered in the index relative to the `HEAD` commit. (One
> -exception is when the changed index entries are in the state that
> -would result from the merge already.)
> +To avoid recording unrelated changes in the merge commit, 'git merge'
> +will also abort if there are any changes registered in the index
> +relative to the `HEAD` commit. (One exception is when the changed
> +index entries are in the state that would result from the merge
> +already.)
OK, so "git pull and git merge" have been updated to say "git
merge" and there is no other change. Looks good.
Please do not re-flow and change in the same commit, by the way.
> @@ -138,14 +133,15 @@ will exit early with the message "Already up-to-date."
> FAST-FORWARD MERGE
> ------------------
>
> -Often the current branch head is an ancestor of the named commit.
> +Often the current branch head is an ancestor of the named commit. In
> +this case, a new commit is not needed to store the combined history;
> +instead, the `HEAD` (along with the index) is updated to point at the
> +named commit, without creating an extra merge commit.
> +
> This is the most common case especially when invoked from 'git
> pull': you are tracking an upstream repository, you have committed
> no local changes, and now you want to update to a newer upstream
> -revision. In this case, a new commit is not needed to store the
> -combined history; instead, the `HEAD` (along with the index) is
> -updated to point at the named commit, without creating an extra
> -merge commit.
> +revision.
I am not sure if the post-image of this hunk is better than the
original.
next prev parent reply other threads:[~2016-10-05 18:57 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-05 14:46 [PATCH 0/6] git-merge: a few documentation improvements sorganov
2016-10-05 14:46 ` [PATCH 1/6] git-merge: clarify "usage" by adding "-m <msg>" sorganov
2016-10-05 17:46 ` Junio C Hamano
2016-10-05 20:41 ` Sergey Organov
2016-10-05 14:46 ` [PATCH 2/6] Documentation/git-merge.txt: remove list of options from SYNOPSIS sorganov
2016-10-05 17:47 ` Junio C Hamano
2016-10-05 21:03 ` Sergey Organov
2016-10-05 14:46 ` [PATCH 3/6] Documentation/git-merge.txt: fix SYNOPSIS of obsolete form to include options sorganov
2016-10-05 14:46 ` [PATCH 4/6] Documentation/git-merge.txt: improve short description in NAME sorganov
2016-10-05 17:52 ` Junio C Hamano
2016-10-05 21:01 ` Sergey Organov
2016-10-05 17:55 ` Jeff King
2016-10-05 20:44 ` Sergey Organov
2016-10-05 14:46 ` [PATCH 5/6] Documentation/git-merge.txt: improve short description in DESCRIPTION sorganov
2016-10-05 16:58 ` Jakub Narębski
2016-10-05 20:01 ` Junio C Hamano
2016-10-05 21:27 ` Sergey Organov
2016-10-06 13:21 ` Sergey Organov
2016-10-05 18:07 ` Junio C Hamano
2016-10-05 21:24 ` Sergey Organov
2016-10-05 21:41 ` Junio C Hamano
2016-10-06 12:30 ` Sergey Organov
2016-10-06 17:46 ` Junio C Hamano
2016-10-07 13:13 ` Sergey Organov
2016-10-05 14:46 ` [PATCH 6/6] Documentation/git-merge.txt: get rid of irrelevant references to git-pull sorganov
2016-10-05 18:57 ` Junio C Hamano [this message]
2016-10-05 21:34 ` Sergey Organov
2016-10-05 21:43 ` Junio C Hamano
2016-10-06 12:39 ` Sergey Organov
2016-10-06 18:06 ` Junio C Hamano
2016-10-07 11:45 ` Sergey Organov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzimioc7s.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=sorganov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.