From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Jeremiah Mahler <jmmahler@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH v2] format-patch --signature-file <file>
Date: Tue, 20 May 2014 08:06:50 -0700 [thread overview]
Message-ID: <xmqqzjic1oc5.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140520062132.GA5222@sigill.intra.peff.net> (Jeff King's message of "Tue, 20 May 2014 02:21:32 -0400")
Jeff King <peff@peff.net> writes:
> You could do:
>
> #define DEFAULT_SIGNATURE git_version_string
> static const char *signature = DEFAULT_SIGNATURE;
>
> ...
>
> if (signature == DEFAULT_SIGNATURE)
> ...
>
> but maybe that is getting a little unwieldy, considering the scope of
> the original problem.
I agree. It is an invitation for doing something like
#define DEFAULT_SIGNATURE "-- \nfoo bar\n"
which defeats the purpose.
I have an unrelated and larger design level suggestion, but it may
be better for me to refrain from sending it during the -rc freeze.
next prev parent reply other threads:[~2014-05-20 15:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 1:31 [PATCH v2] format-patch --signature-file <file> Jeremiah Mahler
2014-05-16 1:31 ` Jeremiah Mahler
2014-05-16 8:14 ` Jeff King
2014-05-17 7:25 ` Jeremiah Mahler
2014-05-17 7:42 ` Jeff King
2014-05-17 8:59 ` Jeremiah Mahler
2014-05-17 10:00 ` Jeff King
2014-05-17 15:39 ` Jeremiah Mahler
2014-05-19 16:54 ` Junio C Hamano
2014-05-20 5:46 ` Jeremiah Mahler
2014-05-20 6:21 ` Jeff King
2014-05-20 15:06 ` Junio C Hamano [this message]
2014-05-21 0:45 ` Jeremiah Mahler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzjic1oc5.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jmmahler@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.