All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Philippe Vaucher <philippe.vaucher@gmail.com>,
	"git\@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH 0/4] remote-hg: more improvements
Date: Mon, 12 May 2014 13:40:02 -0700	[thread overview]
Message-ID: <xmqqzjimpw7x.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <53712cd889ba9_2ea6e1f2f82f@nysa.notmuch> (Felipe Contreras's message of "Mon, 12 May 2014 15:19:36 -0500")

Felipe Contreras <felipe.contreras@gmail.com> writes:

> Junio C Hamano wrote:
> ...
>> I was originally led to believe that its code quality was good
>> enough, and that was why I merged the bottom three patches of the
>> series even down to 'next' in the first place.  But after seeing the
>> "Of course" response that led to [*1*], which made me recall many
>> patch-review interactions with him, I have started to have doubts.
>
> This is bullshit, and a wrong direction fallacy.
>
> Event #1:
> Junio rejects the graduation
> http://article.gmane.org/gmane.comp.version-control.git/248263
>
> Event #2:
> I give up improving remote helpers in git.git
> http://thread.gmane.org/gmane.comp.version-control.git/248063/focus=248341
>
> Junio is trying to make you believe that his decision (#1) was caused by
> something I did (#2). Don't fall into that trap, #2 happened *AFTER* #1,
> it can't possibly be the cause.

I think you misunderstood.

I never said that I do not want it to graduate up (out is an option)
based on code quality.  In fact, I do not think anybody discussed
about code quality until this morning.

But because I was asked, I thought about it, and then answered
honestly.  I do not know what a trap you perceive is about, and I am
not interested in your responses.

  reply	other threads:[~2014-05-12 20:40 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-04  2:16 [PATCH 0/4] remote-hg: more improvements Felipe Contreras
2014-05-04  2:16 ` [PATCH 1/4] remote-hg: add more tests Felipe Contreras
2014-05-04  9:40   ` Eric Sunshine
2014-05-04  2:16 ` [PATCH 2/4] t: remote-hg: add file operation tests Felipe Contreras
2014-05-04  2:16 ` [PATCH 3/4] t: remote-hg: trivial cleanups and fixes Felipe Contreras
2014-05-04  2:16 ` [PATCH 4/4] remote-hg: add support for hg v3.0 Felipe Contreras
2014-05-07 18:12 ` [PATCH 0/4] remote-hg: more improvements Junio C Hamano
2014-05-07 19:01   ` Felipe Contreras
2014-05-07 20:28     ` Junio C Hamano
2014-05-07 20:37       ` Felipe Contreras
2014-05-07 23:59         ` Junio C Hamano
2014-05-08  1:09           ` Felipe Contreras
2014-05-08  1:34             ` James Denholm
2014-05-08 20:15               ` Felipe Contreras
2014-05-11 19:33             ` Philippe Vaucher
2014-05-12 12:19               ` Philippe Vaucher
2014-05-12 19:50               ` Junio C Hamano
2014-05-12 20:19                 ` Felipe Contreras
2014-05-12 20:40                   ` Junio C Hamano [this message]
2014-05-12 22:21                     ` Felipe Contreras
2014-05-14  9:12                 ` Philippe Vaucher
2014-05-14  9:30                   ` David Kastrup
2014-05-14  9:36                     ` Philippe Vaucher
2014-05-14  9:55                       ` David Kastrup
2014-05-14 12:11                         ` Philippe Vaucher
2014-05-14 12:50                           ` David Kastrup
2014-05-14 13:13                             ` Philippe Vaucher
2014-05-14 13:51                               ` David Kastrup
2014-05-14 16:06                                 ` Philippe Vaucher
2014-05-14 20:19                                   ` Felipe Contreras
2014-05-14 20:58                                     ` David Kastrup
2014-05-14 21:39                                       ` Felipe Contreras
2014-05-14 22:12                                         ` David Kastrup
2014-05-14 22:30                                           ` Felipe Contreras
2014-05-15  6:03                                             ` David Kastrup
2014-05-14 22:24                     ` Junio C Hamano
2014-05-14 22:30                       ` David Kastrup
2014-05-14 22:34                         ` Junio C Hamano
2014-05-08  0:00   ` Junio C Hamano
2014-05-08  1:36     ` Felipe Contreras
2014-05-08 18:36       ` Junio C Hamano
2014-05-08 19:56         ` Felipe Contreras
2014-05-08 22:22           ` Junio C Hamano
2014-05-08 22:42             ` Felipe Contreras
2014-05-08 23:06               ` Junio C Hamano
2014-05-08 23:39                 ` Felipe Contreras
2014-05-09  0:23                   ` Felipe Contreras
2014-05-09 17:16                   ` Junio C Hamano
2014-05-09 17:59                     ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqzjimpw7x.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=philippe.vaucher@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.