From: Junio C Hamano <gitster@pobox.com>
To: Monte Goulding <monte@sweattechnologies.com>
Cc: git@vger.kernel.org
Subject: Re: Refspec wildcards for remotes require trailing slash
Date: Tue, 10 Dec 2013 11:14:33 -0800 [thread overview]
Message-ID: <xmqqzjo8tt5y.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <3B290FD1-EF2B-4419-8845-45C5A3B4A3D3@sweattechnologies.com> (Monte Goulding's message of "Tue, 10 Dec 2013 13:32:26 +1100")
Monte Goulding <monte@sweattechnologies.com> writes:
> Before I go ahead and look at what needs to be done for a patch I
> thought it would be polite to ask if there is any reasoning behind
> the trailing slash rule that I'm missing? Or if you are interested
> in changing this behavior at all.
The log messages of the two commits you cited in your message says
that "refs/a/b/* should not match refs/a/b1, but the old code
mistakenly allowed to". As long that fix is not broken, allowing
"refs/a/b*" to match "refs/a/b1" is OK, I would think.
But it is debatable if such a change should allow "refs/a/b*" to
match "refs/a/b/2". Arguments can be made in both ways, and my
knee-jerk reaction is it shouldn't.
next prev parent reply other threads:[~2013-12-10 19:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 2:32 Refspec wildcards for remotes require trailing slash Monte Goulding
2013-12-10 19:14 ` Junio C Hamano [this message]
2013-12-10 19:59 ` Monte Goulding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzjo8tt5y.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=monte@sweattechnologies.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.