From: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>
To: Michael Holzheu <holzheu@linux.vnet.ibm.com>
Cc: bpf@vger.kernel.org, Jiri Olsa <jolsa@redhat.com>
Subject: bpf: jit: s390 64/32 bits for index in tail call
Date: Tue, 25 Jun 2019 19:56:07 +0300 [thread overview]
Message-ID: <xuny36jxppso.fsf@redhat.com> (raw)
Hi!
I have a question about 6651ee070b3124fe9b9db383e3a895a0e4aded65
```
With this patch a tail call generates the following code on s390x:
if (index >= array->map.max_entries)
goto out
000003ff8001c7e4: e31030100016 llgf %r1,16(%r3)
000003ff8001c7ea: ec41001fa065 clgrj %r4,%r1,10,3ff8001c828
```
Do I understand corretly, that it uses 64 bit index value?
"runtime/jit: pass > 32bit index to tail_call"
test_verifier's test fails for me and I see, for example,
/* mov edx, edx */ in the x86 implementation
--
WBR,
Yauheni Kaliuta
next reply other threads:[~2019-06-25 16:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 16:56 Yauheni Kaliuta [this message]
2019-07-03 9:22 ` bpf: jit: s390 64/32 bits for index in tail call Ilya Leoshkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xuny36jxppso.fsf@redhat.com \
--to=yauheni.kaliuta@redhat.com \
--cc=bpf@vger.kernel.org \
--cc=holzheu@linux.vnet.ibm.com \
--cc=jolsa@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.