From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5A07C48BD4 for ; Tue, 25 Jun 2019 16:56:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A3BA22064A for ; Tue, 25 Jun 2019 16:56:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728070AbfFYQ4J (ORCPT ); Tue, 25 Jun 2019 12:56:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57394 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727763AbfFYQ4J (ORCPT ); Tue, 25 Jun 2019 12:56:09 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4850430024AD; Tue, 25 Jun 2019 16:56:09 +0000 (UTC) Received: from astarta.redhat.com (ovpn-116-223.ams2.redhat.com [10.36.116.223]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6D30619C6F; Tue, 25 Jun 2019 16:56:08 +0000 (UTC) From: Yauheni Kaliuta To: Michael Holzheu Cc: bpf@vger.kernel.org, Jiri Olsa Subject: bpf: jit: s390 64/32 bits for index in tail call Date: Tue, 25 Jun 2019 19:56:07 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Tue, 25 Jun 2019 16:56:09 +0000 (UTC) Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Hi! I have a question about 6651ee070b3124fe9b9db383e3a895a0e4aded65 ``` With this patch a tail call generates the following code on s390x: if (index >= array->map.max_entries) goto out 000003ff8001c7e4: e31030100016 llgf %r1,16(%r3) 000003ff8001c7ea: ec41001fa065 clgrj %r4,%r1,10,3ff8001c828 ``` Do I understand corretly, that it uses 64 bit index value? "runtime/jit: pass > 32bit index to tail_call" test_verifier's test fails for me and I see, for example, /* mov edx, edx */ in the x86 implementation -- WBR, Yauheni Kaliuta