From: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Andrii Nakryiko <andriin@fb.com>, bpf <bpf@vger.kernel.org>,
Networking <netdev@vger.kernel.org>,
Alexei Starovoitov <ast@fb.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Kernel Team <kernel-team@fb.com>
Subject: Re: [PATCH v4 bpf-next 5/7] selftests/bpf: replace test_progs and test_maps w/ general rule
Date: Wed, 13 May 2020 04:58:34 +0300 [thread overview]
Message-ID: <xunyimh0ppdh.fsf@redhat.com> (raw)
In-Reply-To: <CAEf4BzbE3UYw_rKAGNW9HQ5AVeebt=PDuRnEiijrwaKxNsdiYg@mail.gmail.com> (Andrii Nakryiko's message of "Tue, 12 May 2020 15:13:18 -0700")
Hi, Andrii!
>>>>> On Tue, 12 May 2020 15:13:18 -0700, Andrii Nakryiko wrote:
> On Tue, May 12, 2020 at 1:16 PM Yauheni Kaliuta
> <yauheni.kaliuta@redhat.com> wrote:
>>
>> Hi, Andrii!
>>
>> The patch blanks TEST_GEN_FILES which was used by install target
>> (lib.mk) to install test progs. How is it supposed to work?
>>
> I actually never used install for selftests, just make and
> then run individual test binaries, which explains why this
> doesn't work :)
Ok :) Thanks for the clarification.
>> That fixes it for me btw:
>>
>> diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
>> index 8f25966b500b..1f878dcd2bf6 100644
>> --- a/tools/testing/selftests/bpf/Makefile
>> +++ b/tools/testing/selftests/bpf/Makefile
>> @@ -265,6 +265,7 @@ TRUNNER_BPF_OBJS := $$(patsubst %.c,$$(TRUNNER_OUTPUT)/%.o, $$(TRUNNER_BPF_SRCS)
>> TRUNNER_BPF_SKELS := $$(patsubst %.c,$$(TRUNNER_OUTPUT)/%.skel.h, \
>> $$(filter-out $(SKEL_BLACKLIST), \
>> $$(TRUNNER_BPF_SRCS)))
>> +TEST_GEN_FILES += $$(TRUNNER_BPF_OBJS)
> Yeah, this makes sense, these files will be copied over along
> the compiled test_xxx binaries. Do you mind submitting a
> patch?
No, sure, I'll do.
--
WBR,
Yauheni Kaliuta
next prev parent reply other threads:[~2020-05-13 1:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 6:00 [PATCH v4 bpf-next 0/7] Fix, clean up, and revamp selftests/bpf Makefile Andrii Nakryiko
2019-10-16 6:00 ` [PATCH v4 bpf-next 1/7] selftests/bpf: teach test_progs to cd into subdir Andrii Nakryiko
2019-10-16 6:00 ` [PATCH v4 bpf-next 2/7] selftests/bpf: make CO-RE reloc test impartial to test_progs flavor Andrii Nakryiko
2019-10-16 6:00 ` [PATCH v4 bpf-next 3/7] selftests/bpf: switch test_maps to test_progs' test.h format Andrii Nakryiko
2019-10-16 6:00 ` [PATCH v4 bpf-next 4/7] selftests/bpf: add simple per-test targets to Makefile Andrii Nakryiko
2019-10-16 6:00 ` [PATCH v4 bpf-next 5/7] selftests/bpf: replace test_progs and test_maps w/ general rule Andrii Nakryiko
2019-10-16 16:32 ` Stanislav Fomichev
2019-10-16 20:47 ` Andrii Nakryiko
2019-10-17 16:07 ` Stanislav Fomichev
2019-10-17 17:48 ` Andrii Nakryiko
2019-10-17 20:44 ` Stanislav Fomichev
2019-10-17 17:50 ` Andrii Nakryiko
2019-10-17 17:54 ` Alexei Starovoitov
2019-10-17 18:19 ` Andrii Nakryiko
2020-05-12 20:16 ` Yauheni Kaliuta
2020-05-12 22:13 ` Andrii Nakryiko
2020-05-13 1:58 ` Yauheni Kaliuta [this message]
2019-10-16 6:00 ` [PATCH v4 bpf-next 6/7] selftests/bpf: move test_queue_stack_map.h into progs/ where it belongs Andrii Nakryiko
2019-10-16 6:00 ` [PATCH v4 bpf-next 7/7] selftest/bpf: remove test_libbpf.sh and test_libbpf_open Andrii Nakryiko
2019-10-17 4:27 ` [PATCH v4 bpf-next 0/7] Fix, clean up, and revamp selftests/bpf Makefile Alexei Starovoitov
2019-10-17 6:52 ` Andrii Nakryiko
2019-10-17 8:08 ` Jakub Sitnicki
2019-10-17 19:18 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xunyimh0ppdh.fsf@redhat.com \
--to=yauheni.kaliuta@redhat.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.