From: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>
To: Omar Sandoval <osandov@osandov.com>
Cc: linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
Lucas De Marchi <lucas.de.marchi@gmail.com>,
Olof Johansson <olof@lixom.net>,
Heiko Stuebner <heiko@sntech.de>
Subject: Re: depmod gets stuck in symlink cycle in arch/arm/boot/dts/include
Date: Sat, 13 May 2017 08:03:09 +0300 [thread overview]
Message-ID: <xunyo9ux9wmq.fsf@redhat.com> (raw)
In-Reply-To: <20170512222307.GA9634@vader.DHCP.thefacebook.com> (Omar Sandoval's message of "Fri, 12 May 2017 15:23:07 -0700")
Hi, Omar!
>>>>> On Fri, 12 May 2017 15:23:07 -0700, Omar Sandoval wrote:
> Hi,
> Linux kernel commit 4027494ae6e3 ("ARM: dts: add arm/arm64 include
> symlinks") introduced a couple of symlink cycles:
> $ ls -al arch/arm{,64}/boot/dts/include
> arch/arm64/boot/dts/include:
> total 12
> drwxr-xr-x 1 osandov users 38 May 11 14:01 .
> drwxr-xr-x 1 osandov users 320 Jan 25 20:44 ..
> lrwxrwxrwx 1 osandov users 24 May 11 14:01 arm -> ../../../../arm/boot/dts
> lrwxrwxrwx 1 osandov users 2 May 11 14:01 arm64 -> ..
> lrwxrwxrwx 1 osandov users 34 Nov 23 12:07 dt-bindings ->
> ../../../../../include/dt-bindings
> arch/arm/boot/dts/include:
> total 12
> drwxr-xr-x 1 osandov users 38 May 11 14:01 .
> drwxr-xr-x 1 osandov users 63102 May 11 14:01 ..
> lrwxrwxrwx 1 osandov users 2 May 11 14:01 arm -> ..
> lrwxrwxrwx 1 osandov users 26 May 11 14:01 arm64 -> ../../../../arm64/boot/dts
> lrwxrwxrwx 1 osandov users 34 Nov 23 12:07 dt-bindings ->
> ../../../../../include/dt-bindings
> On my system, /lib/modules/$(uname -r)/kernel is a symlink to
> /lib/modules/$(uname -r)/build, which is my built linux.git. depmod
> doesn't like these symlink cycles and ends up in an infinite loop.
> Maybe I shouldn't be symlinking kernel to build like this, but depmod
> shouldn't be getting stuck like this either. I wonder if anything else
> is going to barf on these symlink cycles, too.
depmod checks for special names "build" and "source" to skip them.
I wonder if it worth to implement full symlink loop check.
--
WBR,
Yauheni Kaliuta
prev parent reply other threads:[~2017-05-13 5:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-12 22:23 depmod gets stuck in symlink cycle in arch/arm/boot/dts/include Omar Sandoval
2017-05-12 22:55 ` Olof Johansson
2017-05-13 5:03 ` Yauheni Kaliuta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xunyo9ux9wmq.fsf@redhat.com \
--to=yauheni.kaliuta@redhat.com \
--cc=heiko@sntech.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=lucas.de.marchi@gmail.com \
--cc=olof@lixom.net \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.