Re: [PATCH] testsuite: add simple test for --show-exports

[Yauheni Kaliuta <yauheni.kaliuta@redhat.com>]

Hi, Lucas!

>>>>> On Tue, 13 Nov 2018 10:46:40 -0800, Lucas De Marchi  wrote:

 > ---
 >  testsuite/populate-modules.sh                 |  1 +
 >  .../test-modprobe/show-exports/correct.txt    |  1 +
 >  testsuite/test-modprobe.c                     | 22 +++++++++++++++++++
 >  3 files changed, 24 insertions(+)
 >  create mode 100644 testsuite/rootfs-pristine/test-modprobe/show-exports/correct.txt

 > diff --git a/testsuite/populate-modules.sh b/testsuite/populate-modules.sh
 > index b77e71e..ba68a69 100755
 > --- a/testsuite/populate-modules.sh
 > +++ b/testsuite/populate-modules.sh
 > @@ -39,6 +39,7 @@ map=(
 >      ["test-modprobe/show-depends/lib/modules/4.4.4/kernel/mod-loop-a.ko"]="mod-loop-a.ko"
 >      ["test-modprobe/show-depends/lib/modules/4.4.4/kernel/mod-loop-b.ko"]="mod-loop-b.ko"
 >      ["test-modprobe/show-depends/lib/modules/4.4.4/kernel/mod-simple.ko"]="mod-simple.ko"
 > +    ["test-modprobe/show-exports/mod-loop-a.ko"]="mod-loop-a.ko"
 >      ["test-modprobe/softdep-loop/lib/modules/4.4.4/kernel/mod-loop-a.ko"]="mod-loop-a.ko"
 >      ["test-modprobe/softdep-loop/lib/modules/4.4.4/kernel/mod-loop-b.ko"]="mod-loop-b.ko"
 >      ["test-modprobe/install-cmd-loop/lib/modules/4.4.4/kernel/mod-loop-a.ko"]="mod-loop-a.ko"
 > diff --git a/testsuite/rootfs-pristine/test-modprobe/show-exports/correct.txt b/testsuite/rootfs-pristine/test-modprobe/show-exports/correct.txt
 > new file mode 100644
 > index 0000000..bc2d045
 > --- /dev/null
 > +++ b/testsuite/rootfs-pristine/test-modprobe/show-exports/correct.txt
 > @@ -0,0 +1 @@
 > +0x00000000	printA

I'm afraid, it won't work if your kernel is built with
MODVERSIONS enabled.

 > diff --git a/testsuite/test-modprobe.c b/testsuite/test-modprobe.c
 > index ee9d82d..52a6621 100644
 > --- a/testsuite/test-modprobe.c
 > +++ b/testsuite/test-modprobe.c
 > @@ -95,6 +95,28 @@ DEFINE_TEST(modprobe_show_alias_to_none,
 >  	);
 
 
 > +static noreturn int modprobe_show_exports(const struct test *t)
 > +{
 > +	const char *progname = ABS_TOP_BUILDDIR "/tools/modprobe";
 > +	const char *const args[] = {
 > +		progname,
 > +		"--show-exports", "--quiet", "/mod-loop-a.ko",
 > +		NULL,
 > +	};
 > +
 > +	test_spawn_prog(progname, args);
 > +	exit(EXIT_FAILURE);
 > +}
 > +DEFINE_TEST(modprobe_show_exports,
 > +	.description = "check if modprobe --show-depends doesn't explode with an alias to nothing",
 > +	.config = {
 > +		[TC_ROOTFS] = TESTSUITE_ROOTFS "test-modprobe/show-exports",
 > +	},
 > +	.output = {
 > +		.out = TESTSUITE_ROOTFS "test-modprobe/show-exports/correct.txt",
 > +	});
 > +
 > +
 >  static noreturn int modprobe_builtin(const struct test *t)
 >  {
 >  	const char *progname = ABS_TOP_BUILDDIR "/tools/modprobe";
 > -- 
 > 2.19.1.1.g56c4683e68


-- 
WBR,
Yauheni Kaliuta