From: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>
To: "Michal Suchánek" <msuchanek@suse.de>
Cc: Lucas De Marchi <lucas.de.marchi@gmail.com>,
linux-modules <linux-modules@vger.kernel.org>
Subject: Re: [PATCH] libkmod-signature: Fix crash when module signature is not present.
Date: Tue, 13 Mar 2018 12:03:34 +0200 [thread overview]
Message-ID: <xunyy3iw47ih.fsf@redhat.com> (raw)
In-Reply-To: <20180313105739.748518b6@naga.suse.cz> ("Michal \=\?utf-8\?Q\?Suc\?\= \=\?utf-8\?Q\?h\=C3\=A1nek\=22's\?\= message of "Tue, 13 Mar 2018 10:57:39 +0100")
Hi, Michal!
(Leaving in Cc only the list and maintainer)
>>>>> On Tue, 13 Mar 2018 10:57:39 +0100, Michal Suchánek wrote:
> On Mon, 12 Mar 2018 22:41:19 +0200
> Yauheni Kaliuta <yauheni.kaliuta@redhat.com> wrote:
>> Hi, Michal!
>>
>> >>>>> On Thu, 8 Mar 2018 19:14:26 +0100, Michal Suchanek wrote:
>>
>> > The mod_sig is allocated on stack and when no signature is present
>> > it is not initialized and contains garbage. Later when freeing
>> > mod_sig garbage pointer is dereferenced.
>>
>> I guess, it is enough to init the structure.
> Yes, it is enough to initialize the structure. However, this issue is
> caused by the awkward interface to the kmod_module_signature_info
> function so changing the interface should prevent such errors in the
> future.
Frankly, I made the same change of the interface in my initial
implementation before the functionality :) But it's up to Lucas, I guess,
you can send the patch on top of the master already now ready for
applying.
--
WBR,
Yauheni Kaliuta
next prev parent reply other threads:[~2018-03-13 10:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 13:58 [PATCH RFC PKCS7 asn1c 0/2] asn1c version of PKCS#7 parser Yauheni Kaliuta
2018-03-08 13:58 ` [PATCH RFC PKCS7 asn1c 1/2] libkmod-signature: implement pkcs7 parsing with asn1c compiler Yauheni Kaliuta
2018-03-08 18:14 ` [PATCH] libkmod-signature: Fix crash when module signature is not present Michal Suchanek
2018-03-12 20:41 ` Yauheni Kaliuta
2018-03-13 9:57 ` Michal Suchánek
2018-03-13 10:03 ` Yauheni Kaliuta [this message]
2018-06-08 17:10 ` [PATCH] libkmod-signature: pkcs#7: fix crash when signer info " Michal Suchanek
2018-06-11 17:12 ` Lucas De Marchi
2018-06-11 17:42 ` Michal Suchánek
2018-03-08 13:58 ` [PATCH RFC PKCS7 asn1c 2/2] libkmod, pkcs7: commit asn1c autogenerated files Yauheni Kaliuta
2018-03-12 15:45 ` Michal Suchánek
2018-03-12 15:42 ` [PATCH RFC PKCS7 asn1c 0/2] asn1c version of PKCS#7 parser Michal Suchánek
2018-03-12 20:40 ` Yauheni Kaliuta
2018-03-13 9:54 ` Michal Suchánek
2019-01-22 20:01 ` Yauheni Kaliuta
2019-01-22 20:03 ` Michal Suchánek
2019-01-22 20:34 ` Yauheni Kaliuta
2019-01-22 20:43 ` Lucas De Marchi
2019-01-22 22:07 ` Michal Suchánek
2019-01-25 13:40 ` Yauheni Kaliuta
2019-01-23 8:41 ` Yauheni Kaliuta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xunyy3iw47ih.fsf@redhat.com \
--to=yauheni.kaliuta@redhat.com \
--cc=linux-modules@vger.kernel.org \
--cc=lucas.de.marchi@gmail.com \
--cc=msuchanek@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.