From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B78F9C19425 for ; Wed, 9 Dec 2020 20:55:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8365223B99 for ; Wed, 9 Dec 2020 20:55:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387451AbgLIUz3 (ORCPT ); Wed, 9 Dec 2020 15:55:29 -0500 Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:14453 "EHLO hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729804AbgLIUz1 (ORCPT ); Wed, 9 Dec 2020 15:55:27 -0500 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Wed, 09 Dec 2020 12:54:47 -0800 Received: from reg-r-vrt-018-180.nvidia.com (172.20.13.39) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 9 Dec 2020 20:54:42 +0000 References: <20201209092052.19a39676@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com> <838391ff7ffa5dbfb79f30c6d31292c80415af18.camel@kernel.org> User-agent: mu4e 1.4.12; emacs 26.2.90 From: Vlad Buslov To: Eric Dumazet CC: Saeed Mahameed , Jakub Kicinski , Jianlin Shi , CKI Project , netdev , , Yi Zhang , Memory Management , Jan Stancek , Jianwen Ji , Hangbin Liu , Ondrej Moris , Ondrej Mosnacek , Changhui Zhong , Xiong Zhou , Rachel Sibley , David Arcari Subject: Re: =?utf-8?Q?=E2=9D=8C?= FAIL: Test report for kernel 5.10.0-rc6 (mainline.kernel.org) In-Reply-To: Date: Wed, 9 Dec 2020 22:54:40 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [172.20.13.39] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1607547287; bh=mE9KAPYArifMWST5mxBKcbC+LI/egUE1GlqKJdGdC+4=; h=References:User-agent:From:To:CC:Subject:In-Reply-To:Date: Message-ID:MIME-Version:Content-Type:X-Originating-IP: X-ClientProxiedBy; b=QKzYEujc4Vh7J/AMwpce9x3n0Sid28rJ22SWBL0mGvPrjXkgyWpFVUVqw5GuoaRwc CNkiu0I9IjJ+/NRCHks8nKg8WF/egYv+CpjIa07ht3nH3ucMZjHWOcsjF0PAtuhxtp 14bhwtOerIOOIEm8FPEMfyb5U6vdPt5USyufPtQRRe2skpBsTCZtOfidMnwtO8Vflp Q1uX0LLSRB+UvsZ0lQsq1KWoYZFOgDHbGQwrxCX4wcm73RHFXJnGTVLwDcKF1bItys YHD96/z0EpKGoNX1beWQcNgHHNfW+watqe6VTbX3NYvz080CJl9ToGEGMoYDmTnPZe EtBFEVa/9QlbA== Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed 09 Dec 2020 at 20:50, Eric Dumazet wrote: > On Wed, Dec 9, 2020 at 7:34 PM Saeed Mahameed wrote: >> >> On Wed, 2020-12-09 at 19:05 +0100, Eric Dumazet wrote: >> > On Wed, Dec 9, 2020 at 6:35 PM Eric Dumazet >> > wrote: >> > > Hmm... maybe the ECN stuff has always been buggy then, and nobody >> > > cared... >> > > >> > >> > Wait a minute, maybe this part was not needed, >> > >> > diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c >> > index >> > 8ae9ce2014a4a3ba7b962a209e28d1f65d4a83bd..896a7eb61d70340f69b9d3be0f7 >> > 95fbaab1458dd >> > 100644 >> > --- a/drivers/net/geneve.c >> > +++ b/drivers/net/geneve.c >> > @@ -270,7 +270,7 @@ static void geneve_rx(struct geneve_dev *geneve, >> > struct geneve_sock *gs, >> > goto rx_error; >> > break; >> > default: >> > - goto rx_error; >> > + break; >> > } >> > oiph = skb_network_header(skb); >> > skb_reset_network_header(skb); >> > >> > >> > > On Wed, Dec 9, 2020 at 6:20 PM Jakub Kicinski >> > > wrote: >> > > > Eric, could this possibly be commit 4179b00c04d1 ("geneve: pull >> > > > IP >> > > > header before ECN decapsulation")? >> > > > >> >> We've bisected an issue in our CI to this patch, something about geneve >> TC offload traffic not passing, I don't have all the details, Maybe >> Vlad can chime in. >> > > Yes, I think the patch I sent should fix this, ETH_P_ARP should not be > dropped ;) > > I am testing this before offical patch submission. > > Thanks ! Hi Eric, Your patch fixed TC geneve tests for me, but some of more complex OVS tests are still failing. I'll try to provide details tomorrow. Regards, Vlad