From: Vlad Buslov <vladbu@nvidia.com>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Vlad Buslov <vlad@buslov.dev>, <dsahern@gmail.com>,
<stephen@networkplumber.org>, <netdev@vger.kernel.org>,
<davem@davemloft.net>, <xiyou.wangcong@gmail.com>,
<jiri@resnulli.us>, <ivecera@redhat.com>,
Vlad Buslov <vladbu@mellanox.com>
Subject: Re: [PATCH iproute2-next v3 2/2] tc: implement support for terse dump
Date: Mon, 26 Oct 2020 20:03:57 +0200 [thread overview]
Message-ID: <ygnhtuug6f02.fsf@nvidia.com> (raw)
In-Reply-To: <940495a7-d828-7439-a9c3-1e3bde6b02fb@mojatatu.com>
On Mon 26 Oct 2020 at 20:01, Jamal Hadi Salim <jhs@mojatatu.com> wrote:
> On 2020-10-26 1:46 p.m., Vlad Buslov wrote:
>>
>> On Mon 26 Oct 2020 at 19:12, Jamal Hadi Salim <jhs@mojatatu.com> wrote:
>>> On 2020-10-26 7:28 a.m., Vlad Buslov wrote:
>>>>
>>>> On Sat 24 Oct 2020 at 20:40, Jamal Hadi Salim <jhs@mojatatu.com> wrote:
>>>
>>> [..]
>>>>>>
>>>>>> Yes, that makes sense. I guess introducing something like 'tc action -br
>>>>>> ls ..' mode implemented by means of existing terse flag + new 'also
>>>>>> output action index' flag would achieve that goal.
>>>>>>
>>>>>
>>>>> Right. There should be no interest in the cookie here at all. Maybe
>>>>> it could be optional with a flag indication.
>>>>> Have time to cook a patch? I'll taste/test it.
>>>>
>>>> Patch to make cookie in filter terse dump optional? That would break
>>>> existing terse dump users that rely on it (OVS).
>>>
>>> Meant patch for 'tc action -br ls'
>>>
>>> Which by default would not include the cookie.
>>
>> So action-dump-specific flag that causes act api to output action index
>> (via new attribute) and skips cookie?
>>
>
> yeah, something like TCA_ACT_FLAGS_TERSE.
>
> new tcf_action_dump_terse() takes one more field which says to
> include or not the cookies since that is shared code and filters
> can always include it.
> The action index is already present in the passed tc_action
> struct just needs a new TLV.
Sure, I'll try to find time this week.
next prev parent reply other threads:[~2020-10-26 18:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 14:42 [PATCH iproute2-next v3 0/2] Implement filter terse dump mode support Vlad Buslov
2020-10-16 14:42 ` [PATCH iproute2-next v3 1/2] tc: skip actions that don't have options attribute when printing Vlad Buslov
2020-10-16 14:42 ` [PATCH iproute2-next v3 2/2] tc: implement support for terse dump Vlad Buslov
2020-10-16 16:07 ` Jamal Hadi Salim
2020-10-16 16:42 ` Vlad Buslov
2020-10-17 11:20 ` Jamal Hadi Salim
2020-10-18 12:16 ` Vlad Buslov
2020-10-19 13:48 ` Jamal Hadi Salim
2020-10-19 15:18 ` Vlad Buslov
2020-10-20 12:29 ` Jamal Hadi Salim
2020-10-21 8:19 ` Vlad Buslov
2020-10-22 14:05 ` Jamal Hadi Salim
2020-10-23 12:48 ` Vlad Buslov
2020-10-24 17:40 ` Jamal Hadi Salim
2020-10-26 11:28 ` Vlad Buslov
2020-10-26 14:52 ` David Ahern
2020-10-26 15:06 ` Vlad Buslov
2020-10-26 15:17 ` David Ahern
2020-10-26 17:12 ` Jamal Hadi Salim
2020-10-26 17:46 ` Vlad Buslov
2020-10-26 18:01 ` Jamal Hadi Salim
2020-10-26 18:03 ` Vlad Buslov [this message]
2020-10-26 19:56 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ygnhtuug6f02.fsf@nvidia.com \
--to=vladbu@nvidia.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=ivecera@redhat.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=vlad@buslov.dev \
--cc=vladbu@mellanox.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.