From: Guopeng Zhang <zhangguopeng@kylinos.cn>
To: mkoutny@suse.com
Cc: tj@kernel.org, hannes@cmpxchg.org, shuah@kernel.org,
cgroups@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, sebastian.chlad@suse.com,
Guopeng Zhang <zhangguopeng@kylinos.cn>
Subject: Re: [PATCH] selftests/cgroup: conform test to TAP format output
Date: Fri, 14 Nov 2025 11:55:48 +0800 [thread overview]
Message-ID: <your-message-id> (raw)
In-Reply-To: <6lwnagu63xzanum2xx6vkm2qe4oh74fteqeymmkqxyjbovcce6@3jekdivdr7yf>
Hi Michal,
Thanks for reviewing and pointing out [1].
> Could you please explain more why is the TAP layout beneficial?
> (I understand selftest are for oneself, i.e. human readable only by default.)
Actually, selftests are no longer just something for developers to view locally; they are now extensively
run in CI and stable branch regression testing. Using a standardized layout means that general test runners
and CI systems can parse the cgroup test results without any special handling.
TAP provides a structured format that is both human-readable and machine-readable. The plan/result lines are parsed by tools,
while the diagnostic lines can still contain human-readable debug information. Over time, other selftest suites (such as mm, KVM, mptcp, etc.)
have also been converted to TAP-style output, so this change just brings the cgroup tests in line with that broader direction.
> Or is this part of some tree-wide effort?
This patch is not part of a formal, tree-wide conversion series I am running; it is an incremental step to align the
cgroup C tests with the existing TAP usage. I started here because these tests already use ksft_test_result_*() and
only require minor changes to generate proper TAP output.
> I'm asking to better asses whether also the scripts listed in
> Makefile:TEST_PROGS should be converted too.
I agree that having them produce TAP output would benefit tooling and CI. I did not want to mix
that into this change, but if you and other maintainers think this direction is reasonable,
I would be happy to follow up and convert the cgroup shell tests to TAP as well.
Thanks again for your review.
Best regards,
Guopeng
next prev parent reply other threads:[~2025-11-14 3:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-13 9:50 [PATCH] selftests/cgroup: conform test to TAP format output Guopeng Zhang
2025-11-13 10:45 ` Michal Koutný
2025-11-14 3:55 ` Guopeng Zhang [this message]
2026-04-10 21:41 ` [PATCH v2] iio: adc: nxp-sar-adc: use field_get() for EOC bit check Piyush Patle
2026-04-11 14:23 ` Daniel Lezcano
2026-04-19 17:00 ` Piyush Patle
2026-04-20 13:10 ` Jonathan Cameron
[not found] ` <6916a904.9d0a0220.2b5e5.0b79SMTPIN_ADDED_BROKEN@mx.google.com>
2025-11-14 7:04 ` [PATCH] selftests/cgroup: conform test to TAP format output Sebastian Chlad
2025-11-14 9:19 ` Guopeng Zhang
[not found] ` <6916a8f5.050a0220.23bb4.ab7dSMTPIN_ADDED_BROKEN@mx.google.com>
2025-11-14 14:32 ` Michal Koutný
2025-11-15 3:43 ` Guopeng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=your-message-id \
--to=zhangguopeng@kylinos.cn \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mkoutny@suse.com \
--cc=sebastian.chlad@suse.com \
--cc=shuah@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.