All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jes Sorensen <jes@sgi.com>
To: linux-ia64@vger.kernel.org
Subject: Re: FW: [BISECT] Boot failure on ia64.
Date: Tue, 24 Jun 2008 15:30:09 +0000	[thread overview]
Message-ID: <yq0hcbiluke.fsf@jaguar.mkp.net> (raw)
In-Reply-To: <20080624143922.GK10123@sgi.com>

>>>>> "Robin" = Robin Holt <holt@sgi.com> writes:

Robin> Oops, missed sending this to the ia64 mailing list.  Robin

Hi Robin,

Just hit the same problem and did a little digging. It's because
platform_send_ipi() ends up doing a cpuid_to_nasid() on sn2, which
relies on NUMA information etc. being setup. 

In fact, check_sal_cache_flush() is called a fair bit before
platform_setup() in arch/ia64/kernel/setup.c, which I would claim is
completely broken.

Either check_sal_cache_flush() needs to be moved to after
platform_setup() or Alex's patch should be reverted until a better
solution is found. I am attaching a patch that does the former, but I
don't know if this is safe on HP's systems.

This boots on SN2.

Cheers,
Jes

Call check_sal_cache_flush() after platform_setup() as
check_sal_cache_flush() now relies on being able to call platform
vector code.

Signed-off-by: Jes Sorensen <jes@sgi.com>
---
 arch/ia64/kernel/setup.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Index: linux-2.6.git/arch/ia64/kernel/setup.c
=================================--- linux-2.6.git.orig/arch/ia64/kernel/setup.c
+++ linux-2.6.git/arch/ia64/kernel/setup.c
@@ -578,8 +578,6 @@ setup_arch (char **cmdline_p)
 	cpu_init();	/* initialize the bootstrap CPU */
 	mmu_context_init();	/* initialize context_id bitmap */
 
-	check_sal_cache_flush();
-
 #ifdef CONFIG_ACPI
 	acpi_boot_init();
 #endif
@@ -607,6 +605,7 @@ setup_arch (char **cmdline_p)
 		ia64_mca_init();
 
 	platform_setup(cmdline_p);
+	check_sal_cache_flush();
 	paging_init();
 }
 

  reply	other threads:[~2008-06-24 15:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-24 14:39 FW: [BISECT] Boot failure on ia64 Robin Holt
2008-06-24 15:30 ` Jes Sorensen [this message]
2008-06-24 16:35   ` Alex Chiang
2008-06-24 16:35     ` Alex Chiang
2008-06-24 15:41 ` Robin Holt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq0hcbiluke.fsf@jaguar.mkp.net \
    --to=jes@sgi.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.