From: martin.petersen@oracle.com (Martin K. Petersen)
Subject: [PATCH 1/1] nvme: Modify the debug level for setting shutdown timeout
Date: Thu, 04 Jan 2018 12:24:42 -0500 [thread overview]
Message-ID: <yq11sj5v8o5.fsf@oracle.com> (raw)
In-Reply-To: <b46266c8-e239-ac12-d66e-33d613de597b@mellanox.com> (Max Gurtovoy's message of "Thu, 4 Jan 2018 19:04:19 +0200")
Max,
> but shutdown_timeout is a module param that one can set to be 10 secs
> (for example) and then it might be == transition_time and we won't see
> the print. Then is it not a buggy device anymore ? :)
The intent was to only print when the resulting shutdown_timeout
deviated from the default value (whether the driver default or the
admin-provided module parameter).
My only concern with info over warning is that info is often dropped.
And therefore you have a harder time finding out which value was in
effect when you subsequently peak at the logs.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2018-01-04 17:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-31 13:33 [PATCH 1/1] nvme: Modify the debug level for setting shutdown timeout Max Gurtovoy
2018-01-04 10:04 ` Christoph Hellwig
2018-01-04 17:04 ` Max Gurtovoy
2018-01-04 17:24 ` Martin K. Petersen [this message]
2018-01-04 17:48 ` Max Gurtovoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq11sj5v8o5.fsf@oracle.com \
--to=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.