From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Himanshu Madhani <himanshu.madhani@cavium.com>
Cc: James.Bottomley@HansenPartnership.com,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] PCI/MSI: Only disable affinity settings if pre and post vector count is equal to max_vecs and not min_vecs
Date: Wed, 22 Feb 2017 19:27:16 -0500 [thread overview]
Message-ID: <yq11sup92fv.fsf@oracle.com> (raw)
In-Reply-To: <1487698473-4171-1-git-send-email-himanshu.madhani@cavium.com> (Himanshu Madhani's message of "Tue, 21 Feb 2017 09:34:33 -0800")
>>>>> "Himanshu" == Himanshu Madhani <himanshu.madhani@cavium.com> writes:
Himanshu,
Himanshu> min_vecs is the minimum amount of vectors needed to operate in
Himanshu> MSI-X mode which may just include the vectors that don't need
Himanshu> affinity.
Himanshu> Disabling affinity settings causes the qla2xxx driver
Himanshu> scsi_add_host to fail when blk_mq is enabled as the
Himanshu> blk_mq_pci_map_queues expects affinity masks on each vector.
Himanshu> diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c index
[...]
This should go through the PCI tree and not SCSI.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-02-23 0:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-21 17:34 [PATCH] PCI/MSI: Only disable affinity settings if pre and post vector count is equal to max_vecs and not min_vecs Himanshu Madhani
2017-02-23 0:27 ` Martin K. Petersen [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-02-23 6:12 Himanshu Madhani
2017-02-23 10:30 ` Christoph Hellwig
2017-02-23 21:01 Himanshu Madhani
2017-02-28 22:05 ` Madhani, Himanshu
2017-03-01 15:20 ` Christoph Hellwig
2017-03-01 23:27 ` Madhani, Himanshu
2017-03-01 23:31 Himanshu Madhani
2017-03-01 23:49 ` Christoph Hellwig
2017-03-07 19:00 ` Madhani, Himanshu
2017-03-07 21:08 ` Bjorn Helgaas
2017-03-23 17:29 ` Bjorn Helgaas
2017-03-30 23:21 ` Bjorn Helgaas
2017-03-30 23:25 ` Himanshu Madhani
2017-03-31 0:09 ` Bjorn Helgaas
2017-04-17 21:26 Himanshu Madhani
2017-04-18 0:01 ` kbuild test robot
2017-04-18 1:19 Himanshu Madhani
2017-05-17 22:28 ` Bjorn Helgaas
2017-05-18 16:02 ` Himanshu Madhani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq11sup92fv.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=himanshu.madhani@cavium.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.