From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Tomas Winkler <tomas.winkler@intel.com>
Cc: James Bottomley <James.Bottomley@hansenpartnership.com>,
Christoph Hellwig <hch@lst.de>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Douglas Gilbert <dgilbert@interlog.com>
Subject: Re: [scsi 5/7 RESEND] scsi_debug: schedule_resp fix input variable check
Date: Thu, 30 Jul 2015 13:23:32 -0400 [thread overview]
Message-ID: <yq11tfpo8yz.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <1438091666-18113-5-git-send-email-tomas.winkler@intel.com> (Tomas Winkler's message of "Tue, 28 Jul 2015 16:54:24 +0300")
>>>>> "Tomas" == Tomas Winkler <tomas.winkler@intel.com> writes:
Tomas> The function should never be called with cmnd NULL so put a fat
Tomas> WARN there. Fix also smatch wraning: schedule_resp() warn:
Tomas> variable dereferenced before check 'cmnd'
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2015-07-30 17:23 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 13:54 [scsi 1/7 RESEND] scsi_debug: define pr_fmt() for consistent logging Tomas Winkler
2015-07-28 13:54 ` [scsi 2/7 RESEND] scsi_debug: use SCSI_W_LUN_REPORT_LUNS instead of SAM2_WLUN_REPORT_LUNS; Tomas Winkler
2015-07-30 17:22 ` Martin K. Petersen
2015-07-28 13:54 ` [scsi 3/7 RESEND] scsi_debug: vfree is null safe so drop the check Tomas Winkler
2015-07-30 17:22 ` Martin K. Petersen
2015-07-28 13:54 ` [scsi 4/7 RESEND] scsi_debug: make dump_sector static Tomas Winkler
2015-07-30 17:22 ` Martin K. Petersen
2015-07-28 13:54 ` [scsi 5/7 RESEND] scsi_debug: schedule_resp fix input variable check Tomas Winkler
2015-07-30 17:23 ` Martin K. Petersen [this message]
2015-08-25 19:52 ` Ewan Milne
2015-08-25 21:03 ` Winkler, Tomas
2015-08-25 21:03 ` Winkler, Tomas
2015-08-26 23:38 ` James Bottomley
2015-08-27 19:56 ` Ewan Milne
2015-08-30 10:36 ` Winkler, Tomas
2015-08-30 10:36 ` Winkler, Tomas
2015-08-30 16:54 ` James Bottomley
2015-08-31 8:07 ` Winkler, Tomas
2015-08-31 8:07 ` Winkler, Tomas
2015-07-28 13:54 ` [scsi 6/7 RESEND] scsi_debug: fix REPORT LUNS Well Known LU Tomas Winkler
2015-07-30 17:24 ` Martin K. Petersen
2015-07-28 13:54 ` [scsi 7/7] scsi_debug: resp_request: remove unused variable Tomas Winkler
2015-07-30 17:24 ` Martin K. Petersen
2015-07-30 17:24 ` Martin K. Petersen
2015-07-30 17:21 ` [scsi 1/7 RESEND] scsi_debug: define pr_fmt() for consistent logging Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq11tfpo8yz.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=dgilbert@interlog.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.