All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Mike Snitzer <snitzer@redhat.com>
Cc: dm-devel@redhat.com, "Alasdair G. Kergon" <agk@redhat.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH v2] dm: Fix alignment stacking on partitioned devices
Date: Tue, 05 Jan 2010 22:24:59 -0500	[thread overview]
Message-ID: <yq11vi3ud84.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <20100106025731.GA16154@redhat.com> (Mike Snitzer's message of "Tue, 5 Jan 2010 21:57:32 -0500")

>>>>> "Mike" == Mike Snitzer <snitzer@redhat.com> writes:

Mike,

Mike> After looking closer there seems to be various type
Mike> inconsistencies in the alignment_offset and discard_alignment
Mike> related routines (returning 'int' in places, etc).

Mike> The following patch is what I found; I have no problem with
Mike> switching from 'unsigned long' to blk_off_t for LBD though.

I only use blk_off_t in the places where we're dealing with absolute
offsets.

Blindly converting alignment_offset from int to unsigned long won't
work.  We depend on being able to return -1 in case of
misalignment. Hence int and not unsigned int. Furthermore, the returned
values are always modulo the granularity so int is plenty big.

So NAK from here.

-- 
Martin K. Petersen	Oracle Linux Engineering

  parent reply	other threads:[~2010-01-06  3:24 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-23 18:07 [PATCH v2] dm: Fix alignment stacking on partitioned devices Mike Snitzer
2009-12-23 19:21 ` Mike Snitzer
2010-01-05 18:04 ` Alasdair G Kergon
2010-01-05 18:27 ` Alasdair G Kergon
2010-01-06  2:23   ` Martin K. Petersen
2010-01-06  2:57     ` Mike Snitzer
2010-01-06  3:03       ` Mike Snitzer
2010-01-06  3:24       ` Martin K. Petersen [this message]
2010-01-06  4:10         ` Mike Snitzer
2010-01-06  4:16           ` Martin K. Petersen
2010-01-06  5:16             ` Mike Snitzer
2010-01-06  8:39               ` Martin K. Petersen
2010-01-06 13:25                 ` Mike Snitzer
2010-01-07 17:15                   ` Martin K. Petersen
2010-01-07 18:55                     ` Mike Snitzer
2010-01-08 18:41                       ` Martin K. Petersen
2010-01-08 20:28                         ` Mike Snitzer
2010-01-09  0:01                   ` [PATCH] block: bdev_stack_limits wrapper and DM topology fixes Mike Snitzer
2010-01-06 13:55                 ` [PATCH v2] dm: Fix alignment stacking on partitioned devices Alasdair G Kergon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq11vi3ud84.fsf@sermon.lab.mkp.net \
    --to=martin.petersen@oracle.com \
    --cc=agk@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.