From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Jonathan Corbet <corbet@lwn.net>, <linux-doc@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH] docs: filesystems: sysfs: Recommend sysfs_emit() for new code only
Date: Thu, 24 Jul 2025 15:24:42 -0400 [thread overview]
Message-ID: <yq134alv1pv.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20250724153449.2433395-1-bvanassche@acm.org> (Bart Van Assche's message of "Thu, 24 Jul 2025 08:34:42 -0700")
Hi Bart!
> -- show() should only use sysfs_emit() or sysfs_emit_at() when
> formatting
With my standards hat on: That's a "should", not a "shall". But I guess
the "only" makes it sound slightly less optional.
> +- New implementations of show() methods should only use sysfs_emit() or
> + sysfs_emit_at() when formatting the value to be returned to user
> space.
Should we make this a "shall" for new implementations?
I'm fine either way.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen
next prev parent reply other threads:[~2025-07-24 19:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-24 15:34 [PATCH] docs: filesystems: sysfs: Recommend sysfs_emit() for new code only Bart Van Assche
2025-07-24 18:41 ` Greg Kroah-Hartman
2025-07-24 19:24 ` Martin K. Petersen [this message]
2025-08-11 17:16 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq134alv1pv.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bvanassche@acm.org \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.