From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: target-devel@vger.kernel.org
Subject: Re: [PATCH] scsi: ibmvscsi_tgt: Remove target_wait_for_sess_cmd()
Date: Thu, 18 Oct 2018 00:52:45 +0000 [thread overview]
Message-ID: <yq136t4m5ya.fsf@oracle.com> (raw)
In-Reply-To: <1539711249-12634-1-git-send-email-bly@catalogicsoftware.com>
Bryant,
> There is currently a bug with the driver where there is never a call
> to target_sess_cmd_list_set_waiting(), it only called
> target_wait_for_sess_cmd(), which basically means that the
> sess_wait_list would always be empty.
>
> Thus, list_empty(&sess->sess_wait_list) = true, (eg: no se_cmd I/O is
> quiesced, because no se_cmd in sess_wait_list), since commit
> 712db3eb2c35 ("scsi: ibmvscsis: Properly deregister target sessions")
> in 4.9.y code.
>
> ibmvscsi_tgt does not remove the I_T Nexus when a VM is active so we
> can fix this issue by removing the call to target_wait_for_sess_cmd()
> altogether.
Applied to 4.20/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2018-10-18 0:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 17:34 [PATCH] scsi: ibmvscsi_tgt: Remove target_wait_for_sess_cmd() Ly, Bryant
2018-10-17 17:46 ` Mike Christie
2018-10-18 0:52 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq136t4m5ya.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.