From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [PATCH] scsi_transport_fc: Hold queue lock while calling blk_run_queue_async() Date: Mon, 14 Nov 2016 18:26:21 -0500 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from aserp1040.oracle.com ([141.146.126.69]:51038 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753048AbcKNX0f (ORCPT ); Mon, 14 Nov 2016 18:26:35 -0500 In-Reply-To: (Bart Van Assche's message of "Fri, 11 Nov 2016 16:55:50 -0800") Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Bart Van Assche Cc: James Bottomley , "Martin K. Petersen" , Hannes Reinecke , James Smart , "linux-scsi@vger.kernel.org" >>>>> "Bart" == Bart Van Assche writes: Bart> It is required to hold the queue lock when calling Bart> blk_run_queue_async() to avoid that a race between Bart> blk_run_queue_async() and blk_cleanup_queue() is Bart> triggered. Additionally, remove the get_device() and put_device() Bart> calls from fc_bsg_goose_queue. It is namely the responsibility of Bart> the caller of fc_bsg_goose_queue() to ensure that the bsg queue Bart> does not disappear while fc_bsg_goose_queue() is in progress. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering