From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: emilne@redhat.com, Hannes Reinecke <hare@suse.de>,
linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.com>
Subject: Re: [PATCH 2/3] scsi: disable VPD page check on error
Date: Tue, 21 Jun 2016 22:54:41 -0400 [thread overview]
Message-ID: <yq137o62ary.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <1466430242.2350.4.camel@HansenPartnership.com> (James Bottomley's message of "Mon, 20 Jun 2016 06:44:02 -0700")
>>>>> "James" == James Bottomley <James.Bottomley@HansenPartnership.com> writes:
James> I also don't really like this. If the device has a failure like
James> the QEMU one where it just hangs up, this won't help because the
James> problem already happened. Conversely, if the device replies in
James> the negative, it should always do so, so I can't see what this
James> buys us, except the possibility of doing the wrong thing on a
James> transient error
Yeah.
James> I'd be much happier if you can point to a problem that this would
James> solve.
I'd like more details as well.
If we are going to entertain skipping VPD pages on error I would like it
to be as a result of a clear indication that it's the VPD that's the
problem and not just any error returned while querying the page.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2016-06-22 4:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 6:57 [PATCH 0/3] VPD page check consolidation Hannes Reinecke
2016-06-20 6:57 ` [PATCH 1/3] scsi: Move 'scsi_attach_vpd()' prototype to scsi_priv.h Hannes Reinecke
2016-06-20 13:24 ` Ewan D. Milne
2016-06-22 13:22 ` Christoph Hellwig
2016-06-20 6:57 ` [PATCH 2/3] scsi: disable VPD page check on error Hannes Reinecke
2016-06-20 13:25 ` Ewan D. Milne
2016-06-20 13:44 ` James Bottomley
2016-06-20 15:03 ` Ewan D. Milne
2016-06-22 2:54 ` Martin K. Petersen [this message]
2016-06-22 13:23 ` Christoph Hellwig
2016-06-20 6:57 ` [PATCH 3/3] scsi: consolidate checking for VPD pages Hannes Reinecke
2016-06-20 13:26 ` Ewan D. Milne
2016-06-22 13:24 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq137o62ary.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=emilne@redhat.com \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.