From: "Martin K. Petersen" <mkp@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Jack Wang <jinpu.wang@cloud.ionos.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <mkp@kernel.org>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, Elkin Cruz <elkin@google.com>
Subject: Re: [PATCH] scsi: pm8001: Fix abort completion status in pm8001_mpi_task_abort_resp()
Date: Fri, 20 Nov 2026 21:02:29 -0500 [thread overview]
Message-ID: <yq14idbosba.fsf@mail.kernel.org> (raw)
In-Reply-To: <20261119170905.1530613-1-irogers@google.com>
Ian,
> In pm8001_mpi_task_abort_resp(), the IO_NOT_VALID branch assigns
> TMF_RESP_FUNC_FAILED (enum tmf_resp, 5) to ts->resp (enum
> service_response) instead of ts->stat, leaving ts->stat at 0. In
> addition, switch (status) has no default case, so any other non-zero
> firmware abort failure status leaves both ts->resp and ts->stat at
> their zero-initialized values (SAS_TASK_COMPLETE and
> SAS_SAM_STAT_GOOD), causing sas_execute_internal_abort() to falsely
> treat a failed abort as TMF_RESP_FUNC_COMPLETE.
Applied to 7.5/scsi-staging, thanks!
--
Martin K. Petersen
prev parent reply other threads:[~2026-11-21 2:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 17:09 [PATCH] scsi: pm8001: Fix abort completion status in pm8001_mpi_task_abort_resp() Ian Rogers
2026-11-21 2:02 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq14idbosba.fsf@mail.kernel.org \
--to=mkp@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=elkin@google.com \
--cc=irogers@google.com \
--cc=jinpu.wang@cloud.ionos.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=llvm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.